You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by Graeme-Miller <gi...@git.apache.org> on 2015/12/17 17:13:32 UTC

[GitHub] incubator-brooklyn pull request: Various QA changes

GitHub user Graeme-Miller opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/1115

    Various QA changes

    Added LoopOverGroupMembersTestCase. Removed some targeting functionality from BaseTest and added it to a new Interface called TargetabeTestComponent
    
    Made TestCase and ParallelTestCase TargetabeTestComponent
    InfrastructureDeploymentTestCaseImpl can now deploy multiple specs
    TestEffector will now check assertions
    InfrastructureDeploymentTestCaseImpl made more resilient

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Graeme-Miller/incubator-brooklyn qa_add_cluster_test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/1115.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1115
    
----
commit 2b2aa6caacaf2c64c8f07ed481617216c8fc1e9e
Author: Graeme-Miller <gr...@cloudsoftcorp.com>
Date:   2015-12-14T16:32:38Z

    Added LoopOverGroupMembersTestCase. Removed some targeting functionality from BaseTest and added it to a new Interface called TargetabeTestComponent
    Made TestCase and ParallelTestCase TargetabeTestComponent
    InfrastructureDeploymentTestCaseImpl can now deploy multiple specs
    TestEffector will now check assertions
    InfrastructureDeploymentTestCaseImpl made more resilient

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Various QA changes

Posted by Graeme-Miller <gi...@git.apache.org>.
Github user Graeme-Miller commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1115#issuecomment-166632121
  
    @ahgittin docs updated


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Various QA changes

Posted by Graeme-Miller <gi...@git.apache.org>.
Github user Graeme-Miller commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1115#issuecomment-166375883
  
    @ahgittin didn't have time to do docs today, but will look at getting them done tomorrow.
    Is it worth merging this in now before the repo split and I can raise a separate PR for the documentation update?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Various QA changes

Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1115#issuecomment-166261202
  
    Can you update docs for this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Various QA changes

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-brooklyn/pull/1115


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-brooklyn pull request: Various QA changes

Posted by m4rkmckenna <gi...@git.apache.org>.
Github user m4rkmckenna commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/1115#issuecomment-165611214
  
    looks good to me


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---