[GitHub] [couchdb] jaydoane commented on pull request #3831: Consolidate elixir targets and simplify Makefile

[GitBox <gi...@apache.org>]

jaydoane commented on pull request #3831:
URL: https://github.com/apache/couchdb/pull/3831#issuecomment-968350014


   > I find it a little janky to have to keep suite.elixir manually up-to-date.
   
   Same.
   
   > Should we find a way to automate that?
   
   The default behavior of `mix` is to run all tests, so if an up to date suite.elixir would just contain the full list of tests anyhow, I don't know why we couldn't just get rid of suite.elixir and the `--include` line that references it entirely. The only case I can think of that it would be useful is when you want to define a very small set of tests to run (e.g. the quorum tests), which would be harder to do just using exclusion. But it seems like we're just using normal tags for that, so who knows.
   
   > Conversely, do we actually need to keep the suite / skip approach to managing test sets? ExUnit always has a fairly rich tagging and filtering system for constructing test sets. I wouldn't mind at all if e.g. Cloudant folks wanted to add some additional tags to tests so they could exclude / include them as needed for their internal CI setup.
   
   I don't remember the exact requirements that led @iilyak to the current design, but if Cloudant had the ability to add tags, we could maybe dispense with the skip approach.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org