You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/04/18 21:36:18 UTC
[GitHub] [netbeans] premek opened a new pull request #2906: NETBEANS-4150 added a KeyringProvider using libsecret for new versions of Gnome
premek opened a new pull request #2906:
URL: https://github.com/apache/netbeans/pull/2906
Thank you @matthiasblaesing for the libsecret bindings: https://github.com/matthiasblaesing/JNA-Demos/tree/master/LibSecret
I just put it together into GnomeLibSecretProvider.java
Gio.java, Glib.java & Libsecret.java are without a change from your github except I changed the license header with the one from other netbeans files. Is that correct? Or should it have the one you used?
The unit test is passing, I tested saving DB password and proxy password into it from the IDE. Below are some screenshots from how the saved passwords look like in seahorse app in gnome. The gibberish in the last one is part of the test data from the unit test.
I also tested renaming libsecret in my system temporarily and the IDE used the Fallback KeyringProvider then (like before this change).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #2906: NETBEANS-4150 added a KeyringProvider using libsecret for new versions of Gnome
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #2906:
URL: https://github.com/apache/netbeans/pull/2906#discussion_r617844828
##########
File path: platform/keyring.impl/src/org/netbeans/modules/keyring/gnome/libsecret/GnomeLibSecretProvider.java
##########
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.keyring.gnome.libsecret;
+
+import com.sun.jna.Pointer;
+import com.sun.jna.Structure;
+import com.sun.jna.ptr.PointerByReference;
+import java.text.MessageFormat;
+import java.util.MissingResourceException;
+import java.util.logging.Level;
+import java.util.logging.Logger;
+import org.netbeans.modules.keyring.gnome.libsecret.Glib.GError;
+import org.netbeans.modules.keyring.gnome.libsecret.LibSecret.SecretSchema;
+import org.netbeans.modules.keyring.gnome.libsecret.LibSecret.SecretSchemaAttribute;
+import org.netbeans.spi.keyring.KeyringProvider;
+import org.openide.util.NbBundle;
+import org.openide.util.lookup.ServiceProvider;
+
+@ServiceProvider(service = KeyringProvider.class, position = 150)
Review comment:
Ok - I'm on gnome, once I install kwallet (because some dependency pulls it in), I'll see some random KDE tool buckering me, while libsecret will transparently solve this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] dinix2008 commented on a change in pull request #2906: NETBEANS-4150 added a KeyringProvider using libsecret for new versions of Gnome
Posted by GitBox <gi...@apache.org>.
dinix2008 commented on a change in pull request #2906:
URL: https://github.com/apache/netbeans/pull/2906#discussion_r695764780
##########
File path: platform/keyring.impl/src/org/netbeans/modules/keyring/gnome/libsecret/GnomeLibSecretProvider.java
##########
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.keyring.gnome.libsecret;
+
+import com.sun.jna.Native;
+import com.sun.jna.Pointer;
+import com.sun.jna.Structure;
+import com.sun.jna.ptr.PointerByReference;
+import java.io.ByteArrayOutputStream;
+import java.nio.ByteBuffer;
+import java.nio.CharBuffer;
+import java.nio.charset.Charset;
+import java.text.MessageFormat;
+import java.util.MissingResourceException;
+import java.util.logging.Level;
+import java.util.logging.Logger;
+import org.netbeans.modules.keyring.gnome.libsecret.Glib.GError;
+import org.netbeans.modules.keyring.gnome.libsecret.LibSecret.SecretSchema;
+import org.netbeans.modules.keyring.gnome.libsecret.LibSecret.SecretSchemaAttribute;
+import org.netbeans.spi.keyring.KeyringProvider;
+import org.openide.util.NbBundle;
+import org.openide.util.lookup.ServiceProvider;
+
+@ServiceProvider(service = KeyringProvider.class, position = 90)
+public class GnomeLibSecretProvider implements KeyringProvider {
+
+ private static final Logger LOG = Logger.getLogger(GnomeLibSecretProvider.class.getName());
+ private static final String KEY = "key"; // NOI18N
+ private static final Charset CHARSET = Charset.forName(Native.getDefaultStringEncoding());
+
+ private final String appName;
+
+ private SecretSchema secretSchema = null;
+
+ public GnomeLibSecretProvider() {
+ appName = getAppName();
+ }
+
+ private SecretSchema getSchema() {
+ if (secretSchema != null) {
+ return secretSchema;
+ }
+
+ secretSchema = new SecretSchema();
+ secretSchema.name = appName;
+ secretSchema.flags = LibSecret.SECRET_SCHEMA_NONE;
+ secretSchema.attributes[0] = new SecretSchemaAttribute();
+ secretSchema.attributes[0].name = KEY;
+ secretSchema.attributes[0].type = LibSecret.SECRET_SCHEMA_ATTRIBUTE_STRING;
+ return secretSchema;
+ }
+
+ private String getAppName() {
+ try {
+ return MessageFormat.format(
+ NbBundle.getBundle("org.netbeans.core.windows.view.ui.Bundle").getString("CTL_MainWindow_Title_No_Project"),
+ "…");
+ } catch (MissingResourceException x) {
+ return "NetBeans"; // NOI18N
+ }
+ }
+
+ @Override
+ public boolean enabled() {
Review comment:
Perhaps you need to add a check for the type of operating system so that MacProvider on MacOS with libsecret installed (for example, via brew) has higher priority.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] premek commented on a change in pull request #2906: NETBEANS-4150 added a KeyringProvider using libsecret for new versions of Gnome
Posted by GitBox <gi...@apache.org>.
premek commented on a change in pull request #2906:
URL: https://github.com/apache/netbeans/pull/2906#discussion_r617031157
##########
File path: platform/keyring.impl/src/org/netbeans/modules/keyring/gnome/libsecret/GnomeLibSecretProvider.java
##########
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.keyring.gnome.libsecret;
+
+import com.sun.jna.Pointer;
+import com.sun.jna.Structure;
+import com.sun.jna.ptr.PointerByReference;
+import java.text.MessageFormat;
+import java.util.MissingResourceException;
+import java.util.logging.Level;
+import java.util.logging.Logger;
+import org.netbeans.modules.keyring.gnome.libsecret.Glib.GError;
+import org.netbeans.modules.keyring.gnome.libsecret.LibSecret.SecretSchema;
+import org.netbeans.modules.keyring.gnome.libsecret.LibSecret.SecretSchemaAttribute;
+import org.netbeans.spi.keyring.KeyringProvider;
+import org.openide.util.NbBundle;
+import org.openide.util.lookup.ServiceProvider;
+
+@ServiceProvider(service = KeyringProvider.class, position = 150)
+public class GnomeLibSecretProvider implements KeyringProvider {
+
+ private static final Logger LOG = Logger.getLogger(GnomeLibSecretProvider.class.getName());
+ private static final String KEY = "key"; // NOI18N
+
+ private final String appName;
+
+ public GnomeLibSecretProvider() {
+ appName = getAppName();
+ }
+
+ private SecretSchema getSchema() {
Review comment:
That is what I did initially but the way the KeyringProvider interface is being used is that an instance is created and then `enabled` is called on it and if the native library is not present, the `UnsatisfiedLinkError` is catched inside the `enabled` method and it returns false (not enabled).
If the constructor throws the exception (on systems where libsecret is not present) at least the current unit tests failed.
Should we make the field for the `schema` but not initialize it in the constructor but on the first use?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] premek commented on a change in pull request #2906: NETBEANS-4150 added a KeyringProvider using libsecret for new versions of Gnome
Posted by GitBox <gi...@apache.org>.
premek commented on a change in pull request #2906:
URL: https://github.com/apache/netbeans/pull/2906#discussion_r617860995
##########
File path: platform/keyring.impl/src/org/netbeans/modules/keyring/gnome/libsecret/GnomeLibSecretProvider.java
##########
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.keyring.gnome.libsecret;
+
+import com.sun.jna.Pointer;
+import com.sun.jna.Structure;
+import com.sun.jna.ptr.PointerByReference;
+import java.text.MessageFormat;
+import java.util.MissingResourceException;
+import java.util.logging.Level;
+import java.util.logging.Logger;
+import org.netbeans.modules.keyring.gnome.libsecret.Glib.GError;
+import org.netbeans.modules.keyring.gnome.libsecret.LibSecret.SecretSchema;
+import org.netbeans.modules.keyring.gnome.libsecret.LibSecret.SecretSchemaAttribute;
+import org.netbeans.spi.keyring.KeyringProvider;
+import org.openide.util.NbBundle;
+import org.openide.util.lookup.ServiceProvider;
+
+@ServiceProvider(service = KeyringProvider.class, position = 150)
Review comment:
now I understand what you mean. I changed it to 90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] premek commented on a change in pull request #2906: NETBEANS-4150 added a KeyringProvider using libsecret for new versions of Gnome
Posted by GitBox <gi...@apache.org>.
premek commented on a change in pull request #2906:
URL: https://github.com/apache/netbeans/pull/2906#discussion_r615457717
##########
File path: platform/keyring.impl/src/org/netbeans/modules/keyring/gnome/libsecret/GnomeLibSecretProvider.java
##########
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.keyring.gnome.libsecret;
+
+import com.sun.jna.Pointer;
+import com.sun.jna.Structure;
+import com.sun.jna.ptr.PointerByReference;
+import java.text.MessageFormat;
+import java.util.MissingResourceException;
+import java.util.logging.Level;
+import java.util.logging.Logger;
+import org.netbeans.modules.keyring.gnome.libsecret.Glib.GError;
+import org.netbeans.modules.keyring.gnome.libsecret.LibSecret.SecretSchema;
+import org.netbeans.modules.keyring.gnome.libsecret.LibSecret.SecretSchemaAttribute;
+import org.netbeans.spi.keyring.KeyringProvider;
+import org.openide.util.NbBundle;
+import org.openide.util.lookup.ServiceProvider;
+
+@ServiceProvider(service = KeyringProvider.class, position = 150)
+public class GnomeLibSecretProvider implements KeyringProvider {
+
+ private static final Logger LOG = Logger.getLogger(GnomeLibSecretProvider.class.getName());
+ private static final String KEY = "key"; // NOI18N
+
+ private final String appName;
+ private final LibSecret.SecretSchema schema;
+
+ public GnomeLibSecretProvider() {
+ appName = getAppName();
+
+ schema = new SecretSchema();
+ schema.name = appName;
+ schema.flags = LibSecret.SECRET_SCHEMA_NONE;
+ schema.attributes[0] = new SecretSchemaAttribute();
+ schema.attributes[0].name = KEY;
+ schema.attributes[0].type = LibSecret.SECRET_SCHEMA_ATTRIBUTE_STRING;
+ }
+
+ private String getAppName() {
Review comment:
copied from the old GnomeProvider
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] premek commented on pull request #2906: NETBEANS-4150 added a KeyringProvider using libsecret for new versions of Gnome
Posted by GitBox <gi...@apache.org>.
premek commented on pull request #2906:
URL: https://github.com/apache/netbeans/pull/2906#issuecomment-823645976
One more thing to consider regarding libsecret is this https://nvd.nist.gov/vuln/detail/CVE-2018-19358
When the user is logged in, the keyring is unlocked and other apps can read the passwords, but looks like it is being used like this anyway...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] premek commented on a change in pull request #2906: NETBEANS-4150 added a KeyringProvider using libsecret for new versions of Gnome
Posted by GitBox <gi...@apache.org>.
premek commented on a change in pull request #2906:
URL: https://github.com/apache/netbeans/pull/2906#discussion_r615457644
##########
File path: platform/keyring.impl/src/org/netbeans/modules/keyring/gnome/libsecret/GnomeLibSecretProvider.java
##########
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.keyring.gnome.libsecret;
+
+import com.sun.jna.Pointer;
+import com.sun.jna.Structure;
+import com.sun.jna.ptr.PointerByReference;
+import java.text.MessageFormat;
+import java.util.MissingResourceException;
+import java.util.logging.Level;
+import java.util.logging.Logger;
+import org.netbeans.modules.keyring.gnome.libsecret.Glib.GError;
+import org.netbeans.modules.keyring.gnome.libsecret.LibSecret.SecretSchema;
+import org.netbeans.modules.keyring.gnome.libsecret.LibSecret.SecretSchemaAttribute;
+import org.netbeans.spi.keyring.KeyringProvider;
+import org.openide.util.NbBundle;
+import org.openide.util.lookup.ServiceProvider;
+
+@ServiceProvider(service = KeyringProvider.class, position = 150)
Review comment:
150 is higher than (= after) the old Gnome provider but lower than (=before) the FallbackProvider
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #2906: NETBEANS-4150 added a KeyringProvider using libsecret for new versions of Gnome
Posted by GitBox <gi...@apache.org>.
matthiasblaesing merged pull request #2906:
URL: https://github.com/apache/netbeans/pull/2906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2906: NETBEANS-4150 added a KeyringProvider using libsecret for new versions of Gnome
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2906:
URL: https://github.com/apache/netbeans/pull/2906#issuecomment-825150748
Thank you again - looks sane and worked for me.
Just for the record: Merging this assumes, that you agree that you donate the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] premek commented on a change in pull request #2906: NETBEANS-4150 added a KeyringProvider using libsecret for new versions of Gnome
Posted by GitBox <gi...@apache.org>.
premek commented on a change in pull request #2906:
URL: https://github.com/apache/netbeans/pull/2906#discussion_r617025101
##########
File path: platform/keyring.impl/src/org/netbeans/modules/keyring/gnome/libsecret/GnomeLibSecretProvider.java
##########
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.keyring.gnome.libsecret;
+
+import com.sun.jna.Pointer;
+import com.sun.jna.Structure;
+import com.sun.jna.ptr.PointerByReference;
+import java.text.MessageFormat;
+import java.util.MissingResourceException;
+import java.util.logging.Level;
+import java.util.logging.Logger;
+import org.netbeans.modules.keyring.gnome.libsecret.Glib.GError;
+import org.netbeans.modules.keyring.gnome.libsecret.LibSecret.SecretSchema;
+import org.netbeans.modules.keyring.gnome.libsecret.LibSecret.SecretSchemaAttribute;
+import org.netbeans.spi.keyring.KeyringProvider;
+import org.openide.util.NbBundle;
+import org.openide.util.lookup.ServiceProvider;
+
+@ServiceProvider(service = KeyringProvider.class, position = 150)
Review comment:
I believe [libsecret](https://wiki.gnome.org/Projects/Libsecret) is a gnome project, the underlying d-bus interface should be the same on gnome and kde.
My thinking here was to put it **after** the existing implementation so if the existing one works and is being used, nothing would change (and break)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] premek commented on a change in pull request #2906: NETBEANS-4150 added a KeyringProvider using libsecret for new versions of Gnome
Posted by GitBox <gi...@apache.org>.
premek commented on a change in pull request #2906:
URL: https://github.com/apache/netbeans/pull/2906#discussion_r615457732
##########
File path: platform/keyring.impl/src/org/netbeans/modules/keyring/gnome/libsecret/GnomeLibSecretProvider.java
##########
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.keyring.gnome.libsecret;
+
+import com.sun.jna.Pointer;
+import com.sun.jna.Structure;
+import com.sun.jna.ptr.PointerByReference;
+import java.text.MessageFormat;
+import java.util.MissingResourceException;
+import java.util.logging.Level;
+import java.util.logging.Logger;
+import org.netbeans.modules.keyring.gnome.libsecret.Glib.GError;
+import org.netbeans.modules.keyring.gnome.libsecret.LibSecret.SecretSchema;
+import org.netbeans.modules.keyring.gnome.libsecret.LibSecret.SecretSchemaAttribute;
+import org.netbeans.spi.keyring.KeyringProvider;
+import org.openide.util.NbBundle;
+import org.openide.util.lookup.ServiceProvider;
+
+@ServiceProvider(service = KeyringProvider.class, position = 150)
+public class GnomeLibSecretProvider implements KeyringProvider {
+
+ private static final Logger LOG = Logger.getLogger(GnomeLibSecretProvider.class.getName());
+ private static final String KEY = "key"; // NOI18N
+
+ private final String appName;
+ private final LibSecret.SecretSchema schema;
+
+ public GnomeLibSecretProvider() {
+ appName = getAppName();
+
+ schema = new SecretSchema();
+ schema.name = appName;
+ schema.flags = LibSecret.SECRET_SCHEMA_NONE;
+ schema.attributes[0] = new SecretSchemaAttribute();
+ schema.attributes[0].name = KEY;
+ schema.attributes[0].type = LibSecret.SECRET_SCHEMA_ATTRIBUTE_STRING;
+ }
+
+ private String getAppName() {
+ try {
+ return MessageFormat.format(
+ NbBundle.getBundle("org.netbeans.core.windows.view.ui.Bundle").getString("CTL_MainWindow_Title_No_Project"),
+ "…");
+ } catch (MissingResourceException x) {
+ return "NetBeans"; // NOI18N
+ }
+ }
+
+ @Override
+ public boolean enabled() {
+ if (Boolean.getBoolean("netbeans.keyring.no.native")) {
Review comment:
copied from the old GnomeProvider
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] premek commented on a change in pull request #2906: NETBEANS-4150 added a KeyringProvider using libsecret for new versions of Gnome
Posted by GitBox <gi...@apache.org>.
premek commented on a change in pull request #2906:
URL: https://github.com/apache/netbeans/pull/2906#discussion_r617861494
##########
File path: platform/keyring.impl/src/org/netbeans/modules/keyring/gnome/libsecret/GnomeLibSecretProvider.java
##########
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.keyring.gnome.libsecret;
+
+import com.sun.jna.Pointer;
+import com.sun.jna.Structure;
+import com.sun.jna.ptr.PointerByReference;
+import java.text.MessageFormat;
+import java.util.MissingResourceException;
+import java.util.logging.Level;
+import java.util.logging.Logger;
+import org.netbeans.modules.keyring.gnome.libsecret.Glib.GError;
+import org.netbeans.modules.keyring.gnome.libsecret.LibSecret.SecretSchema;
+import org.netbeans.modules.keyring.gnome.libsecret.LibSecret.SecretSchemaAttribute;
+import org.netbeans.spi.keyring.KeyringProvider;
+import org.openide.util.NbBundle;
+import org.openide.util.lookup.ServiceProvider;
+
+@ServiceProvider(service = KeyringProvider.class, position = 150)
+public class GnomeLibSecretProvider implements KeyringProvider {
+
+ private static final Logger LOG = Logger.getLogger(GnomeLibSecretProvider.class.getName());
+ private static final String KEY = "key"; // NOI18N
+
+ private final String appName;
+
+ public GnomeLibSecretProvider() {
+ appName = getAppName();
+ }
+
+ private SecretSchema getSchema() {
Review comment:
I changed it so the schema is only initialised on the first access
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] premek commented on pull request #2906: NETBEANS-4150 added a KeyringProvider using libsecret for new versions of Gnome
Posted by GitBox <gi...@apache.org>.
premek commented on pull request #2906:
URL: https://github.com/apache/netbeans/pull/2906#issuecomment-824344162
Thanks Matthias for the review, I updated the PR so it doesn't use Strings for passwords (and fixed the other things you mentioned). The related unit tests are still passing on my machine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2906: NETBEANS-4150 added a KeyringProvider using libsecret for new versions of Gnome
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2906:
URL: https://github.com/apache/netbeans/pull/2906#issuecomment-824326261
> One more thing to consider regarding libsecret is this https://nvd.nist.gov/vuln/detail/CVE-2018-19358
> When the user is logged in, the keyring is unlocked and other apps can read the passwords, but looks like it is being used like this anyway...
The CVE for me falls into the "works as intended" category. If your application runs on a level where it can acccess the whole dbus and thus runs as a local application, it can trivially modify local programms and thus you are already screwed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] premek edited a comment on pull request #2906: NETBEANS-4150 added a KeyringProvider using libsecret for new versions of Gnome
Posted by GitBox <gi...@apache.org>.
premek edited a comment on pull request #2906:
URL: https://github.com/apache/netbeans/pull/2906#issuecomment-823645111
I'm trying not to use Strings as you suggested but I'm struggling with passing the unit tests right now, I will try again and let you know.
The two commits I force pushed are just to fix my name and email in those commits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] premek commented on a change in pull request #2906: NETBEANS-4150 added a KeyringProvider using libsecret for new versions of Gnome
Posted by GitBox <gi...@apache.org>.
premek commented on a change in pull request #2906:
URL: https://github.com/apache/netbeans/pull/2906#discussion_r615458049
##########
File path: platform/keyring.impl/src/org/netbeans/modules/keyring/gnome/libsecret/GnomeLibSecretProvider.java
##########
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.keyring.gnome.libsecret;
+
+import com.sun.jna.Pointer;
+import com.sun.jna.Structure;
+import com.sun.jna.ptr.PointerByReference;
+import java.text.MessageFormat;
+import java.util.MissingResourceException;
+import java.util.logging.Level;
+import java.util.logging.Logger;
+import org.netbeans.modules.keyring.gnome.libsecret.Glib.GError;
+import org.netbeans.modules.keyring.gnome.libsecret.LibSecret.SecretSchema;
+import org.netbeans.modules.keyring.gnome.libsecret.LibSecret.SecretSchemaAttribute;
+import org.netbeans.spi.keyring.KeyringProvider;
+import org.openide.util.NbBundle;
+import org.openide.util.lookup.ServiceProvider;
+
+@ServiceProvider(service = KeyringProvider.class, position = 150)
+public class GnomeLibSecretProvider implements KeyringProvider {
+
+ private static final Logger LOG = Logger.getLogger(GnomeLibSecretProvider.class.getName());
+ private static final String KEY = "key"; // NOI18N
+
+ private final String appName;
+ private final LibSecret.SecretSchema schema;
+
+ public GnomeLibSecretProvider() {
+ appName = getAppName();
+
+ schema = new SecretSchema();
+ schema.name = appName;
+ schema.flags = LibSecret.SECRET_SCHEMA_NONE;
+ schema.attributes[0] = new SecretSchemaAttribute();
+ schema.attributes[0].name = KEY;
+ schema.attributes[0].type = LibSecret.SECRET_SCHEMA_ATTRIBUTE_STRING;
+ }
+
+ private String getAppName() {
+ try {
+ return MessageFormat.format(
+ NbBundle.getBundle("org.netbeans.core.windows.view.ui.Bundle").getString("CTL_MainWindow_Title_No_Project"),
+ "…");
+ } catch (MissingResourceException x) {
+ return "NetBeans"; // NOI18N
+ }
+ }
+
+ @Override
+ public boolean enabled() {
+ if (Boolean.getBoolean("netbeans.keyring.no.native")) {
+ LOG.fine("native keyring integration disabled");
+ return false;
+ }
+
+ try {
+ read("NoNeXiStEnT"); // NOI18N
+ return true;
+ } catch (RuntimeException e) {
+ LOG.log(Level.FINE, null, e);
+ return false;
+ }
+ }
+
+ @Override
+ public char[] read(String key) {
+ PointerByReference gerrorBuffer = new PointerByReference();
+
+ Pointer pointer = LibSecret.INSTANCE.secret_password_lookup_sync(schema, null, gerrorBuffer, KEY, key);
+
+ if (gerrorBuffer.getValue() != null) {
+ processError(gerrorBuffer);
+ return null;
+ }
+
+ if (pointer == null) {
+ return null;
+ }
+
+ String secret = pointer.getString(0);
+ if (secret == null) {
+ LOG.warning("Secret is null");
+ return null;
+ }
+
+ return secret.toCharArray();
+ }
+
+ @Override
+ public void save(String key, char[] password, String description) {
+ PointerByReference gerrorBuffer = new PointerByReference();
+
+ String label = appName + " - " + (description != null ? description : key);
+ LibSecret.INSTANCE.secret_password_store_sync(schema, LibSecret.SECRET_COLLECTION_DEFAULT, label, new String(password), null, gerrorBuffer, KEY, key);
+
+ if (gerrorBuffer.getValue() != null) {
+ processError(gerrorBuffer);
+ }
+ }
+
+ @Override
+ public void delete(String key) {
+ PointerByReference gerrorBuffer = new PointerByReference();
+
+ LibSecret.INSTANCE.secret_password_clear_sync(schema, null, gerrorBuffer, KEY, key);
+
+ if (gerrorBuffer.getValue() != null) {
+ processError(gerrorBuffer);
+ }
+ }
+
+ private void processError(PointerByReference gerrorBuffer) throws IllegalArgumentException {
Review comment:
the old GnomeProvider also does not throw exceptions when the native code returns an error, just returns null in case of `read` and just logs the error in case of `read`, `save` and `delete`.
It throws an exception when the native library is not available which is used in the `enabled` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #2906: NETBEANS-4150 added a KeyringProvider using libsecret for new versions of Gnome
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #2906:
URL: https://github.com/apache/netbeans/pull/2906#discussion_r616905236
##########
File path: platform/keyring.impl/src/org/netbeans/modules/keyring/gnome/libsecret/GnomeLibSecretProvider.java
##########
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.keyring.gnome.libsecret;
+
+import com.sun.jna.Pointer;
+import com.sun.jna.Structure;
+import com.sun.jna.ptr.PointerByReference;
+import java.text.MessageFormat;
+import java.util.MissingResourceException;
+import java.util.logging.Level;
+import java.util.logging.Logger;
+import org.netbeans.modules.keyring.gnome.libsecret.Glib.GError;
+import org.netbeans.modules.keyring.gnome.libsecret.LibSecret.SecretSchema;
+import org.netbeans.modules.keyring.gnome.libsecret.LibSecret.SecretSchemaAttribute;
+import org.netbeans.spi.keyring.KeyringProvider;
+import org.openide.util.NbBundle;
+import org.openide.util.lookup.ServiceProvider;
+
+@ServiceProvider(service = KeyringProvider.class, position = 150)
+public class GnomeLibSecretProvider implements KeyringProvider {
+
+ private static final Logger LOG = Logger.getLogger(GnomeLibSecretProvider.class.getName());
+ private static final String KEY = "key"; // NOI18N
+
+ private final String appName;
+
+ public GnomeLibSecretProvider() {
+ appName = getAppName();
+ }
+
+ private SecretSchema getSchema() {
+ SecretSchema schema = new SecretSchema();
+ schema.name = appName;
+ schema.flags = LibSecret.SECRET_SCHEMA_NONE;
+ schema.attributes[0] = new SecretSchemaAttribute();
+ schema.attributes[0].name = KEY;
+ schema.attributes[0].type = LibSecret.SECRET_SCHEMA_ATTRIBUTE_STRING;
+ return schema;
+ }
+
+ private String getAppName() {
+ try {
+ return MessageFormat.format(
+ NbBundle.getBundle("org.netbeans.core.windows.view.ui.Bundle").getString("CTL_MainWindow_Title_No_Project"),
+ "…");
+ } catch (MissingResourceException x) {
+ return "NetBeans"; // NOI18N
+ }
+ }
+
+ @Override
+ public boolean enabled() {
+ if (Boolean.getBoolean("netbeans.keyring.no.native")) {
+ LOG.fine("native keyring integration disabled");
+ return false;
+ }
+
+ try {
+ read("NoNeXiStEnT"); // NOI18N
Review comment:
I assume, this is needed to trigger library loading? That would at least be consistent with the caught `UnsatisfiedLinkError`
##########
File path: platform/keyring.impl/src/org/netbeans/modules/keyring/gnome/libsecret/GnomeLibSecretProvider.java
##########
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.keyring.gnome.libsecret;
+
+import com.sun.jna.Pointer;
+import com.sun.jna.Structure;
+import com.sun.jna.ptr.PointerByReference;
+import java.text.MessageFormat;
+import java.util.MissingResourceException;
+import java.util.logging.Level;
+import java.util.logging.Logger;
+import org.netbeans.modules.keyring.gnome.libsecret.Glib.GError;
+import org.netbeans.modules.keyring.gnome.libsecret.LibSecret.SecretSchema;
+import org.netbeans.modules.keyring.gnome.libsecret.LibSecret.SecretSchemaAttribute;
+import org.netbeans.spi.keyring.KeyringProvider;
+import org.openide.util.NbBundle;
+import org.openide.util.lookup.ServiceProvider;
+
+@ServiceProvider(service = KeyringProvider.class, position = 150)
+public class GnomeLibSecretProvider implements KeyringProvider {
+
+ private static final Logger LOG = Logger.getLogger(GnomeLibSecretProvider.class.getName());
+ private static final String KEY = "key"; // NOI18N
+
+ private final String appName;
+
+ public GnomeLibSecretProvider() {
+ appName = getAppName();
+ }
+
+ private SecretSchema getSchema() {
Review comment:
I would make the Schema a final variable created in the constructor -a single instance should be enough for us.
##########
File path: platform/keyring.impl/src/org/netbeans/modules/keyring/gnome/libsecret/GnomeLibSecretProvider.java
##########
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.keyring.gnome.libsecret;
+
+import com.sun.jna.Pointer;
+import com.sun.jna.Structure;
+import com.sun.jna.ptr.PointerByReference;
+import java.text.MessageFormat;
+import java.util.MissingResourceException;
+import java.util.logging.Level;
+import java.util.logging.Logger;
+import org.netbeans.modules.keyring.gnome.libsecret.Glib.GError;
+import org.netbeans.modules.keyring.gnome.libsecret.LibSecret.SecretSchema;
+import org.netbeans.modules.keyring.gnome.libsecret.LibSecret.SecretSchemaAttribute;
+import org.netbeans.spi.keyring.KeyringProvider;
+import org.openide.util.NbBundle;
+import org.openide.util.lookup.ServiceProvider;
+
+@ServiceProvider(service = KeyringProvider.class, position = 150)
Review comment:
I have mixed feelings here. LibSecret can integrate with gnome _and_ kde keyring, so it might be an argument to raise it above both, if it is present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #2906: NETBEANS-4150 added a KeyringProvider using libsecret for new versions of Gnome
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #2906:
URL: https://github.com/apache/netbeans/pull/2906#discussion_r617845868
##########
File path: platform/keyring.impl/src/org/netbeans/modules/keyring/gnome/libsecret/GnomeLibSecretProvider.java
##########
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.keyring.gnome.libsecret;
+
+import com.sun.jna.Pointer;
+import com.sun.jna.Structure;
+import com.sun.jna.ptr.PointerByReference;
+import java.text.MessageFormat;
+import java.util.MissingResourceException;
+import java.util.logging.Level;
+import java.util.logging.Logger;
+import org.netbeans.modules.keyring.gnome.libsecret.Glib.GError;
+import org.netbeans.modules.keyring.gnome.libsecret.LibSecret.SecretSchema;
+import org.netbeans.modules.keyring.gnome.libsecret.LibSecret.SecretSchemaAttribute;
+import org.netbeans.spi.keyring.KeyringProvider;
+import org.openide.util.NbBundle;
+import org.openide.util.lookup.ServiceProvider;
+
+@ServiceProvider(service = KeyringProvider.class, position = 150)
+public class GnomeLibSecretProvider implements KeyringProvider {
+
+ private static final Logger LOG = Logger.getLogger(GnomeLibSecretProvider.class.getName());
+ private static final String KEY = "key"; // NOI18N
+
+ private final String appName;
+
+ public GnomeLibSecretProvider() {
+ appName = getAppName();
+ }
+
+ private SecretSchema getSchema() {
Review comment:
You can fill schema in the "enable" call - in the same `try` block as all further calls are required to happen only after `enable` was successfully called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] premek commented on a change in pull request #2906: NETBEANS-4150 added a KeyringProvider using libsecret for new versions of Gnome
Posted by GitBox <gi...@apache.org>.
premek commented on a change in pull request #2906:
URL: https://github.com/apache/netbeans/pull/2906#discussion_r617033108
##########
File path: platform/keyring.impl/src/org/netbeans/modules/keyring/gnome/libsecret/GnomeLibSecretProvider.java
##########
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.keyring.gnome.libsecret;
+
+import com.sun.jna.Pointer;
+import com.sun.jna.Structure;
+import com.sun.jna.ptr.PointerByReference;
+import java.text.MessageFormat;
+import java.util.MissingResourceException;
+import java.util.logging.Level;
+import java.util.logging.Logger;
+import org.netbeans.modules.keyring.gnome.libsecret.Glib.GError;
+import org.netbeans.modules.keyring.gnome.libsecret.LibSecret.SecretSchema;
+import org.netbeans.modules.keyring.gnome.libsecret.LibSecret.SecretSchemaAttribute;
+import org.netbeans.spi.keyring.KeyringProvider;
+import org.openide.util.NbBundle;
+import org.openide.util.lookup.ServiceProvider;
+
+@ServiceProvider(service = KeyringProvider.class, position = 150)
+public class GnomeLibSecretProvider implements KeyringProvider {
+
+ private static final Logger LOG = Logger.getLogger(GnomeLibSecretProvider.class.getName());
+ private static final String KEY = "key"; // NOI18N
+
+ private final String appName;
+
+ public GnomeLibSecretProvider() {
+ appName = getAppName();
+ }
+
+ private SecretSchema getSchema() {
+ SecretSchema schema = new SecretSchema();
+ schema.name = appName;
+ schema.flags = LibSecret.SECRET_SCHEMA_NONE;
+ schema.attributes[0] = new SecretSchemaAttribute();
+ schema.attributes[0].name = KEY;
+ schema.attributes[0].type = LibSecret.SECRET_SCHEMA_ATTRIBUTE_STRING;
+ return schema;
+ }
+
+ private String getAppName() {
+ try {
+ return MessageFormat.format(
+ NbBundle.getBundle("org.netbeans.core.windows.view.ui.Bundle").getString("CTL_MainWindow_Title_No_Project"),
+ "…");
+ } catch (MissingResourceException x) {
+ return "NetBeans"; // NOI18N
+ }
+ }
+
+ @Override
+ public boolean enabled() {
+ if (Boolean.getBoolean("netbeans.keyring.no.native")) {
+ LOG.fine("native keyring integration disabled");
+ return false;
+ }
+
+ try {
+ read("NoNeXiStEnT"); // NOI18N
Review comment:
This is based on how the current GnomeProvider worked. Attempting to read a secret would return the secret or null if it does not exist but it throws UnsatisfiedLinkError if the native library is not present. This is used to detect if the Provider will be used or not (enabled)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] premek commented on pull request #2906: NETBEANS-4150 added a KeyringProvider using libsecret for new versions of Gnome
Posted by GitBox <gi...@apache.org>.
premek commented on pull request #2906:
URL: https://github.com/apache/netbeans/pull/2906#issuecomment-823645111
I'm trying not to use Strings as you suggested but I'm struggling with passing the unit tests right now, I will try again and let you know
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists