You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/10/07 13:13:51 UTC
[GitHub] [solr] Caa52 opened a new pull request #333: SOLR-15613: Address error-prone URLEqualsHashCode warning
Caa52 opened a new pull request #333:
URL: https://github.com/apache/solr/pull/333
https://issues.apache.org/jira/browse/SOLR-15613
# Description
Enforce error-prone checks to catch all `URLEqualsHashCode `violations
# Solution
Fixed every `URLEqualsHashCode` violation to use `java.net.URI` instead
# Tests
This was a new feature change to the code. The code passed all original tests.
# Checklist
Please review the following and check all that apply:
- [X] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [X] I have created a Jira issue and added the issue ID to my pull request title.
- [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [X] I have developed this patch against the `main` branch.
- [X] I have run `./gradlew check`.
- [X] I have added tests for my changes.
- [X] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob merged pull request #333: SOLR-15613: Address error-prone URLEqualsHashCode warning
Posted by GitBox <gi...@apache.org>.
madrob merged pull request #333:
URL: https://github.com/apache/solr/pull/333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on a change in pull request #333: SOLR-15613: Address error-prone URLEqualsHashCode warning
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #333:
URL: https://github.com/apache/solr/pull/333#discussion_r724278442
##########
File path: solr/core/src/test/org/apache/solr/search/function/TestMinMaxOnMultiValuedField.java
##########
@@ -895,8 +895,8 @@ private void testExpectedSortOrdering(final String sort,
/**
* Given a (multivalued) field name and an (ascending) sorted list of values, this method will generate a List of Solr Documents of the same size such that:
* <ul>
- * <li>For each non-null value in the original list, the corrisponding document in the result will have that value in the specified field.</li>
- * <li>For each null value in the original list, the corrisponding document in teh result will have <em>NO</em> values in the specified field.</li>
+ * <li>For each non-null value in the original list, the corresponding document in the result will have that value in the specified field.</li>
+ * <li>For each null value in the original list, the corresponding document in teh result will have <em>NO</em> values in the specified field.</li>
Review comment:
this looks unrelated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org