You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/12/15 13:05:37 UTC
[GitHub] [lucene] benwtrent opened a new pull request, #12024: Fix SimpleTextKnnVectorsReader to handle changes introduced in GITHUB#12004
benwtrent opened a new pull request, #12024:
URL: https://github.com/apache/lucene/pull/12024
`SimpleTextKnnVectorsReader` is used for recreation and testing. It needs to handle the new way of searching with BytesRef directly instead of always searching with `float`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jpountz commented on a diff in pull request #12024: Fix SimpleTextKnnVectorsReader to handle changes introduced in GITHUB#12004
Posted by GitBox <gi...@apache.org>.
jpountz commented on code in PR #12024:
URL: https://github.com/apache/lucene/pull/12024#discussion_r1049643447
##########
lucene/core/src/test/org/apache/lucene/search/TestVectorScorer.java:
##########
@@ -36,13 +36,26 @@
public class TestVectorScorer extends LuceneTestCase {
public void testFindAll() throws IOException {
+ VectorEncoding encoding =
+ VectorEncoding.values()[random().nextInt(VectorEncoding.values().length)];
Review Comment:
Nit: use RandomPicks#randomFrom?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] benwtrent commented on a diff in pull request #12024: Fix SimpleTextKnnVectorsReader to handle changes introduced in GITHUB#12004
Posted by GitBox <gi...@apache.org>.
benwtrent commented on code in PR #12024:
URL: https://github.com/apache/lucene/pull/12024#discussion_r1049648525
##########
lucene/core/src/test/org/apache/lucene/search/TestVectorScorer.java:
##########
@@ -36,13 +36,26 @@
public class TestVectorScorer extends LuceneTestCase {
public void testFindAll() throws IOException {
+ VectorEncoding encoding =
+ VectorEncoding.values()[random().nextInt(VectorEncoding.values().length)];
Review Comment:
pushed a commit addressing this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jpountz merged pull request #12024: Fix SimpleTextKnnVectorsReader to handle changes introduced in GITHUB#12004
Posted by GitBox <gi...@apache.org>.
jpountz merged PR #12024:
URL: https://github.com/apache/lucene/pull/12024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org