[jira] [Created] (TAP5-2585) Expression Issues (CronExpression.java and GenericsUtils.java)

["AppChecker (JIRA)" <ji...@apache.org>]

AppChecker created TAP5-2585:
--------------------------------

             Summary: Expression Issues (CronExpression.java and GenericsUtils.java)
                 Key: TAP5-2585
                 URL: https://issues.apache.org/jira/browse/TAP5-2585
             Project: Tapestry 5
          Issue Type: Bug
          Components: tapestry-ioc
    Affects Versions: 5.4.3
            Reporter: AppChecker


Hi
Please look following fragments of source code:
1) [tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/cron/CronExpression.java#L937|https://github.com/apache/tapestry-5/blob/95a548ec488a3c09c16117a0e6f9d3ce28db0322/tapestry-ioc/src/main/java/org/apache/tapestry5/ioc/internal/services/cron/CronExpression.java#L937]
{code:java}for (; i < s.length() && (s.charAt(i) != ' ' || s.charAt(i) != '\t'); i++)
{code}
Expression (s.charAt\(i) != ' ' || s.charAt\(i) != '\t') is always true.
Probably, is should be:

{code:java}
(s.charAt(i) != ' ' && s.charAt(i) != '\t')
{code}

2) [commons/src/main/java/org/apache/tapestry5/ioc/internal/util/GenericsUtils.java#L577|https://github.com/apache/tapestry-5/blob/95a548ec488a3c09c16117a0e6f9d3ce28db0322/commons/src/main/java/org/apache/tapestry5/ioc/internal/util/GenericsUtils.java#L577]

{code:java}
isSuper ? toString(wt.getLowerBounds()) : toString(wt.getLowerBounds()));
{code}

It is strange that the parts of the ternary operator are same.

These possible defect found by [AppChecker|https://npo-echelon.ru/en/solutions/appchecker.php].



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)