You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "pdxrunner (GitHub)" <gi...@apache.org> on 2018/12/18 18:42:18 UTC
[GitHub] [geode] pdxrunner opened pull request #3017: GEODE-6219: Add
assertion to verify the OS commands really ran
Failure of netstat command on the test instance was not being detected.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [X] Is your initial contribution a single, squashed commit?
- [X] Does `gradlew build` run cleanly?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/3017 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] Petahhh commented on pull request #3017: GEODE-6219:
Add assertion to verify the OS commands really ran
Posted by "Petahhh (GitHub)" <gi...@apache.org>.
Can we add a jira ticket number that address this?
[ Full content available at: https://github.com/apache/geode/pull/3017 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] pdxrunner closed pull request #3017: GEODE-6219: Add
assertion to verify the OS commands really ran
Posted by "pdxrunner (GitHub)" <gi...@apache.org>.
[ pull request closed by pdxrunner ]
[ Full content available at: https://github.com/apache/geode/pull/3017 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] Petahhh commented on pull request #3017: GEODE-6219:
Add assertion to verify the OS commands really ran
Posted by "Petahhh (GitHub)" <gi...@apache.org>.
Should this be GEODE-2488 too?
[ Full content available at: https://github.com/apache/geode/pull/3017 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org