You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jim Apple (Code Review)" <ge...@cloudera.org> on 2016/09/12 21:24:37 UTC
[Impala-ASF-CR] IMPALA-3918: Fix straggler Cloudera -> ASF license headers
Jim Apple has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4386
Change subject: IMPALA-3918: Fix straggler Cloudera -> ASF license headers
......................................................................
IMPALA-3918: Fix straggler Cloudera -> ASF license headers
Change-Id: Ief3e09ac93137f870b7fb31a0bc851f24a17573b
---
M common/thrift/beeswax.thrift
M fe/src/test/java/com/cloudera/impala/common/FrontendTestBase.java
2 files changed, 32 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/4386/1
--
To view, visit http://gerrit.cloudera.org:8080/4386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief3e09ac93137f870b7fb31a0bc851f24a17573b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
[Impala-ASF-CR] IMPALA-3918: Fix straggler Cloudera -> ASF license headers
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Hello Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4386
to look at the new patch set (#2).
Change subject: IMPALA-3918: Fix straggler Cloudera -> ASF license headers
......................................................................
IMPALA-3918: Fix straggler Cloudera -> ASF license headers
beeswax.thrift was originally copied from Hive, which is also an ASF
project.
Change-Id: Ief3e09ac93137f870b7fb31a0bc851f24a17573b
---
M common/thrift/beeswax.thrift
M fe/src/test/java/com/cloudera/impala/common/FrontendTestBase.java
2 files changed, 32 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/4386/2
--
To view, visit http://gerrit.cloudera.org:8080/4386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ief3e09ac93137f870b7fb31a0bc851f24a17573b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[Impala-ASF-CR] IMPALA-3918: Fix straggler Cloudera -> ASF license headers
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-3918: Fix straggler Cloudera -> ASF license headers
......................................................................
Patch Set 2: Code-Review+2
> lgtm, though it might be a good idea to document the reasoning that
> the "relicense" is OK in the commit message so that if anyone is
> auditing the provenance of these files through git history later,
> you have some trail of why you decided to replace the license
> header.
Done, carry Alex's +2.
--
To view, visit http://gerrit.cloudera.org:8080/4386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief3e09ac93137f870b7fb31a0bc851f24a17573b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3918: Fix straggler Cloudera -> ASF license headers
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-3918: Fix straggler Cloudera -> ASF license headers
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief3e09ac93137f870b7fb31a0bc851f24a17573b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3918: Fix straggler Cloudera -> ASF license headers
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: IMPALA-3918: Fix straggler Cloudera -> ASF license headers
......................................................................
Patch Set 1:
lgtm, though it might be a good idea to document the reasoning that the "relicense" is OK in the commit message so that if anyone is auditing the provenance of these files through git history later, you have some trail of why you decided to replace the license header.
--
To view, visit http://gerrit.cloudera.org:8080/4386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief3e09ac93137f870b7fb31a0bc851f24a17573b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3918: Fix straggler Cloudera -> ASF license headers
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-3918: Fix straggler Cloudera -> ASF license headers
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief3e09ac93137f870b7fb31a0bc851f24a17573b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3918: Fix straggler Cloudera -> ASF license headers
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-3918: Fix straggler Cloudera -> ASF license headers
......................................................................
IMPALA-3918: Fix straggler Cloudera -> ASF license headers
beeswax.thrift was originally copied from Hive, which is also an ASF
project.
Change-Id: Ief3e09ac93137f870b7fb31a0bc851f24a17573b
Reviewed-on: http://gerrit.cloudera.org:8080/4386
Reviewed-by: Jim Apple <jb...@cloudera.com>
Tested-by: Internal Jenkins
---
M common/thrift/beeswax.thrift
M fe/src/test/java/com/cloudera/impala/common/FrontendTestBase.java
2 files changed, 32 insertions(+), 30 deletions(-)
Approvals:
Jim Apple: Looks good to me, approved
Internal Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief3e09ac93137f870b7fb31a0bc851f24a17573b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>