You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/10/05 08:56:10 UTC
[GitHub] [hive] kasakrisz opened a new pull request #2697: HIVE-25590: Able to create views referencing temporary tables and materialized views
kasakrisz opened a new pull request #2697:
URL: https://github.com/apache/hive/pull/2697
### What changes were proposed in this pull request?
When validating view/materialized view instead of checking the tables in the top QB object check all TableScan operators for temp tables and MVs
### Why are the changes needed?
Checking the top QB object is often not enough: subqueries may contain MV and temp table scans.
### Does this PR introduce _any_ user-facing change?
Yes. At create [materialized]view if view definition has subqueries referencing temp tables and/or materialized views an error message is printed.
### How was this patch tested?
```
mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestNegativeLlapLocalCliDriver -Dqfile=materialized_view_create_failure.q,create_view_failure11.q,create_view_failure12.q -pl itests/qtest -Pitests
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kasakrisz merged pull request #2697: HIVE-25590: Able to create views referencing temporary tables and materialized views
Posted by GitBox <gi...@apache.org>.
kasakrisz merged pull request #2697:
URL: https://github.com/apache/hive/pull/2697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] asolimando edited a comment on pull request #2697: HIVE-25590: Able to create views referencing temporary tables and materialized views
Posted by GitBox <gi...@apache.org>.
asolimando edited a comment on pull request #2697:
URL: https://github.com/apache/hive/pull/2697#issuecomment-934396405
I did run tests with `-Dtest.output.overwrite` like in the PR description, and I did not notice the discrepancies in the `.q.out` files.
Maybe it's better to remove the option from the "How it was tested" example to avoid somebody else getting fooled by this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kasakrisz commented on pull request #2697: HIVE-25590: Able to create views referencing temporary tables and materialized views
Posted by GitBox <gi...@apache.org>.
kasakrisz commented on pull request #2697:
URL: https://github.com/apache/hive/pull/2697#issuecomment-934575532
I usually use `-Dtest.output.overwrite` and then `git status` to see if there were any change because if any of the q.out files changed I can do a better diff.
Anyway I removed `-Dtest.output.overwrite` from the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kasakrisz edited a comment on pull request #2697: HIVE-25590: Able to create views referencing temporary tables and materialized views
Posted by GitBox <gi...@apache.org>.
kasakrisz edited a comment on pull request #2697:
URL: https://github.com/apache/hive/pull/2697#issuecomment-934575532
@asolimando
I usually use `-Dtest.output.overwrite` and then `git status` to see if there were any change because if any of the q.out files changed I can do a better diff.
Anyway I removed `-Dtest.output.overwrite` from the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] asolimando commented on pull request #2697: HIVE-25590: Able to create views referencing temporary tables and materialized views
Posted by GitBox <gi...@apache.org>.
asolimando commented on pull request #2697:
URL: https://github.com/apache/hive/pull/2697#issuecomment-934396405
I did run it with `-Dtest.output.overwrite` like in the PR title, and I did not notice the discrepancies in the `.q.out` files.
Maybe it's better to remove the option from the "How it was tested" example to avoid somebody else getting fooled by this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org