You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/07/08 20:27:04 UTC
[jira] [Commented] (DRILL-3313) Eliminate redundant #load methods
and unit-test loading & exporting of vectors
[ https://issues.apache.org/jira/browse/DRILL-3313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619106#comment-14619106 ]
ASF GitHub Bot commented on DRILL-3313:
---------------------------------------
GitHub user hnfgns opened a pull request:
https://github.com/apache/drill/pull/81
DRILL-3313: Eliminate redundant #load methods and unit-test loading & exporting of vectors
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hnfgns/incubator-drill DRILL-3313
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/81.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #81
----
commit ef79c18d408582dc07b83c8f62075d2329216bd1
Author: Hanifi Gunes <hg...@maprtech.com>
Date: 2015-06-23T19:05:45Z
DRILL-3313: Eliminate redundant #load methods and unit-test loading & exporting of vectors
----
> Eliminate redundant #load methods and unit-test loading & exporting of vectors
> ------------------------------------------------------------------------------
>
> Key: DRILL-3313
> URL: https://issues.apache.org/jira/browse/DRILL-3313
> Project: Apache Drill
> Issue Type: Sub-task
> Components: Execution - Data Types
> Affects Versions: 1.0.0
> Reporter: Hanifi Gunes
> Assignee: Hanifi Gunes
> Fix For: 1.2.0
>
>
> Vectors have multiple #load methods that are used to populate data from raw buffers. It is relatively tough to reason, maintain and unit-test loading and exporting of data since there is many redundant code around load methods. This issue proposes to have single #load method conforming to VV#load(def, buffer) signature eliminating all other #load overrides.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)