You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Michael Osipov (Jira)" <ji...@apache.org> on 2022/05/22 08:18:00 UTC
[jira] [Closed] (SCM-943) scm:check-local-modification does not support excludes
[ https://issues.apache.org/jira/browse/SCM-943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Osipov closed SCM-943.
------------------------------
Resolution: Fixed
Fixed with [bbd23dcfa9fced2c5a2f91abb47be1c4a660e6ea|https://gitbox.apache.org/repos/asf?p=maven-scm.git;a=commit;h=bbd23dcfa9fced2c5a2f91abb47be1c4a660e6ea] and with [d7107dac448fa0117c35726e5ea52260340f3574|https://gitbox.apache.org/repos/asf?p=maven-scm.git;a=commit;h=d7107dac448fa0117c35726e5ea52260340f3574] for {{maven-scm-1.x}} branch.
> scm:check-local-modification does not support excludes
> ------------------------------------------------------
>
> Key: SCM-943
> URL: https://issues.apache.org/jira/browse/SCM-943
> Project: Maven SCM
> Issue Type: Improvement
> Reporter: Michiel Kalkman
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 1.13.0, 2.0.0-M2
>
>
> It seems like scm:check-local-modification does not support the excludes and includes parameters. Which is annoying, because I want to exclude *.iml from Intellij from this check.
> Looking (but not yet testing) at CheckLocalModificationsMojo::execute(), it does:
> {code:java}
> result = getScmManager().status( repository, new ScmFileSet( baseDirectory ) );
> {code}
> So it does not address neither includes, nor excludes parameter.
> My first though would be that something like this is the start of fix:
> {code:java}
> result = getScmManager().status( repository, new ScmFileSet( getWorkingDirectory(), getIncludes(), getExcludes() ) );
> {code}
> Is this something that has not yet been implemented, or is there a user error on my part?
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)