You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iceberg.apache.org by fo...@apache.org on 2025/08/03 19:04:00 UTC
(iceberg-python) branch fd-fix-small-things created (now e980caab)
This is an automated email from the ASF dual-hosted git repository.
fokko pushed a change to branch fd-fix-small-things
in repository https://gitbox.apache.org/repos/asf/iceberg-python.git
at e980caab Thanks Kevin!
This branch includes the following new commits:
new e980caab Thanks Kevin!
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
(iceberg-python) 01/01: Thanks Kevin!
Posted by fo...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
fokko pushed a commit to branch fd-fix-small-things
in repository https://gitbox.apache.org/repos/asf/iceberg-python.git
commit e980caabd6dd8d32a34ce845729420653f2dd857
Author: Fokko Driesprong <fo...@apache.org>
AuthorDate: Sun Aug 3 21:03:40 2025 +0200
Thanks Kevin!
---
tests/conftest.py | 16 ++++++++--------
tests/utils/test_manifest.py | 18 +++++++++---------
2 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/tests/conftest.py b/tests/conftest.py
index 1cb11c70..e5572483 100644
--- a/tests/conftest.py
+++ b/tests/conftest.py
@@ -1258,8 +1258,8 @@ manifest_entry_records = [
{"key": 15, "value": 0},
],
"lower_bounds": [
- {"key": 2, "value": b"2020-04-01 00:00"},
- {"key": 3, "value": b"2020-04-01 00:12"},
+ {"key": 2, "value": b"\x01\x00\x00\x00"},
+ {"key": 3, "value": b"\x01\x00\x00\x00"},
{"key": 7, "value": b"\x03\x00\x00\x00"},
{"key": 8, "value": b"\x01\x00\x00\x00"},
{"key": 10, "value": b"\xf6(\\\x8f\xc2\x05S\xc0"},
@@ -1273,8 +1273,8 @@ manifest_entry_records = [
{"key": 19, "value": b"\x00\x00\x00\x00\x00\x00\x04\xc0"},
],
"upper_bounds": [
- {"key": 2, "value": b"2020-04-30 23:5:"},
- {"key": 3, "value": b"2020-05-01 00:41"},
+ {"key": 2, "value": b"\x06\x00\x00\x00"},
+ {"key": 3, "value": b"\x06\x00\x00\x00"},
{"key": 7, "value": b"\t\x01\x00\x00"},
{"key": 8, "value": b"\t\x01\x00\x00"},
{"key": 10, "value": b"\xcd\xcc\xcc\xcc\xcc,_@"},
@@ -1379,8 +1379,8 @@ manifest_entry_records = [
],
"lower_bounds": [
{"key": 1, "value": b"\x01\x00\x00\x00"},
- {"key": 2, "value": b"2020-04-01 00:00"},
- {"key": 3, "value": b"2020-04-01 00:03"},
+ {"key": 2, "value": b"\x01\x00\x00\x00"},
+ {"key": 3, "value": b"\x01\x00\x00\x00"},
{"key": 4, "value": b"\x00\x00\x00\x00"},
{"key": 5, "value": b"\x01\x00\x00\x00"},
{"key": 6, "value": b"N"},
@@ -1399,8 +1399,8 @@ manifest_entry_records = [
],
"upper_bounds": [
{"key": 1, "value": b"\x01\x00\x00\x00"},
- {"key": 2, "value": b"2020-04-30 23:5:"},
- {"key": 3, "value": b"2020-05-01 00:1:"},
+ {"key": 2, "value": b"\x06\x00\x00\x00"},
+ {"key": 3, "value": b"\x06\x00\x00\x00"},
{"key": 4, "value": b"\x06\x00\x00\x00"},
{"key": 5, "value": b"c\x00\x00\x00"},
{"key": 6, "value": b"Y"},
diff --git a/tests/utils/test_manifest.py b/tests/utils/test_manifest.py
index fc68a2fc..21025634 100644
--- a/tests/utils/test_manifest.py
+++ b/tests/utils/test_manifest.py
@@ -153,8 +153,8 @@ def test_read_manifest_entry(generated_manifest_entry_file: str) -> None:
}
assert data_file.nan_value_counts == {16: 0, 17: 0, 18: 0, 19: 0, 10: 0, 11: 0, 12: 0, 13: 0, 14: 0, 15: 0}
assert data_file.lower_bounds == {
- 2: b"2020-04-01 00:00",
- 3: b"2020-04-01 00:12",
+ 2: b"\x01\x00\x00\x00",
+ 3: b"\x01\x00\x00\x00",
7: b"\x03\x00\x00\x00",
8: b"\x01\x00\x00\x00",
10: b"\xf6(\\\x8f\xc2\x05S\xc0",
@@ -168,8 +168,8 @@ def test_read_manifest_entry(generated_manifest_entry_file: str) -> None:
19: b"\x00\x00\x00\x00\x00\x00\x04\xc0",
}
assert data_file.upper_bounds == {
- 2: b"2020-04-30 23:5:",
- 3: b"2020-05-01 00:41",
+ 2: b"\x06\x00\x00\x00",
+ 3: b"\x06\x00\x00\x00",
7: b"\t\x01\x00\x00",
8: b"\t\x01\x00\x00",
10: b"\xcd\xcc\xcc\xcc\xcc,_@",
@@ -397,7 +397,7 @@ def test_write_manifest(
expected_metadata = {
"schema": test_schema.model_dump_json(),
- "partition-spec": """[{"source-id":1,"field-id":1000,"transform":"identity","name":"VendorID"},{"source-id":2,"field-id":1001,"transform":"day","name":"tpep_pickup_datetime"}]""",
+ "partition-spec": """[{"source-id":1,"field-id":1000,"transform":"identity","name":"VendorID"},{"source-id":2,"field-id":1001,"transform":"day","name":"tpep_pickup_day"}]""",
"partition-spec-id": str(demo_manifest_file.partition_spec_id),
"format-version": str(format_version),
}
@@ -490,8 +490,8 @@ def test_write_manifest(
}
assert data_file.nan_value_counts == {16: 0, 17: 0, 18: 0, 19: 0, 10: 0, 11: 0, 12: 0, 13: 0, 14: 0, 15: 0}
assert data_file.lower_bounds == {
- 2: b"2020-04-01 00:00",
- 3: b"2020-04-01 00:12",
+ 2: b"\x01\x00\x00\x00",
+ 3: b"\x01\x00\x00\x00",
7: b"\x03\x00\x00\x00",
8: b"\x01\x00\x00\x00",
10: b"\xf6(\\\x8f\xc2\x05S\xc0",
@@ -505,8 +505,8 @@ def test_write_manifest(
19: b"\x00\x00\x00\x00\x00\x00\x04\xc0",
}
assert data_file.upper_bounds == {
- 2: b"2020-04-30 23:5:",
- 3: b"2020-05-01 00:41",
+ 2: b"\x06\x00\x00\x00",
+ 3: b"\x06\x00\x00\x00",
7: b"\t\x01\x00\x00",
8: b"\t\x01\x00\x00",
10: b"\xcd\xcc\xcc\xcc\xcc,_@",