You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "michaeljmarshall (via GitHub)" <gi...@apache.org> on 2023/02/23 19:20:49 UTC

[GitHub] [pulsar] michaeljmarshall opened a new pull request, #19616: [improve][broker] Store nonBlank clientVersions that have spaces

michaeljmarshall opened a new pull request, #19616:
URL: https://github.com/apache/pulsar/pull/19616

   Relates to: https://github.com/apache/pulsar/pull/19540
   
   ### Motivation
   
   We currently filter out the `clientVersion` when it has a `" "` in it. As a consequence, we filter out the go client's version because of how it is made:
   
   https://github.com/apache/pulsar-client-go/blob/dedbdc45c63b06e6a12356785418cd906d6bab3c/pulsar/internal/version.go#L43
   
   Given that we do not have any documented restrictions on the `clientVersion`, I think we should not drop clients that have a space in their name.
   
   I propose that we remove the filter logic to store all "valid" versions supplied by the client.
   
   ### Modifications
   
   * Update `ServerCnx` to store `clientVersion` when it has a space in its name.
   
   ### Verifying this change
   
   A new test is added.
   
   ### Does this pull request potentially affect one of the following parts:
   
   This is a backwards compatible change.
   
   ### Documentation
   
   - [x] `doc-not-needed`
   
   ### Matching PR in forked repository
   
   PR in forked repository: skipping for this minor change that shouldn't make any tests fail


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall commented on pull request #19616: [improve][broker] Store nonBlank clientVersions that have spaces

Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall commented on PR #19616:
URL: https://github.com/apache/pulsar/pull/19616#issuecomment-1442309843

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] michaeljmarshall merged pull request #19616: [improve][broker] Store nonBlank clientVersions that have spaces

Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall merged PR #19616:
URL: https://github.com/apache/pulsar/pull/19616


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org