[GitHub] [spark] vanzin commented on a change in pull request #25369: [SPARK-28638][WebUI] Task summary metrics are wrong when there are running tasks

[GitBox <gi...@apache.org>]

vanzin commented on a change in pull request #25369: [SPARK-28638][WebUI] Task summary metrics are wrong when there are running tasks
URL: https://github.com/apache/spark/pull/25369#discussion_r312247763
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala
 ##########
 @@ -156,7 +162,8 @@ private[spark] class AppStatusStore(
     // cheaper for disk stores (avoids deserialization).
     val count = {
       Utils.tryWithResource(
-        if (store.isInstanceOf[InMemoryStore]) {
+        if (isInMemoryStore) {
 
 Review comment:
   I guess the underlying question you guys are asking is: should the metrics count only successful tasks, or all non-failed tasks?
   
   I don't remember the behavior in 2.2 (which is what #23088 was trying to emulate?), which should have the correct answer.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org