You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "David Sledge (JIRA)" <ji...@apache.org> on 2010/03/03 21:34:27 UTC

[jira] Created: (LANG-597) Add more utility methods for generic types

Add more utility methods for generic types
------------------------------------------

                 Key: LANG-597
                 URL: https://issues.apache.org/jira/browse/LANG-597
             Project: Commons Lang
          Issue Type: Improvement
          Components: lang.reflect.*
         Environment: Java 1.5+
            Reporter: David Sledge
            Priority: Minor
             Fix For: 3.0


Added type utilities include:
* checking if one type can be assigned to another type
* determining if a value can be assigned to a given generic variable
* for a class that declares type variables, determining what the type arguments would be based on a generic sub or super type
* determining if a group of types satisfy the bounds of a group of type variables

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (LANG-597) Add more utility methods for generic types

Posted by "Matt Benson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LANG-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Benson resolved LANG-597.
------------------------------

    Resolution: Fixed

Thanks for the extremely large patch!  I finally made time to review and, as I'm sure you knew, it far surpasses what we already had in place.  Applied as r963845

> Add more utility methods for generic types
> ------------------------------------------
>
>                 Key: LANG-597
>                 URL: https://issues.apache.org/jira/browse/LANG-597
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.reflect.*
>         Environment: Java 1.5+
>            Reporter: David M. Sledge
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: TypeUtils-Added-Utitlities-Lang-597-2010-03-18.patch
>
>
> Added type utilities include:
> * checking if one type can be assigned to another type
> * determining if a value can be assigned to a given generic type
> * for a class that declares type variables, determining what the type arguments would be based on a generic sub or super type
> * determining if a group of types satisfy the bounds of a group of type variables

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (LANG-597) Add more utility methods for generic types

Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LANG-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846519#action_12846519 ] 

Henri Yandell commented on LANG-597:
------------------------------------

Can we have the patch without the Copyright statement at the top? It gets confusing to mix all the various copyright statements in the source; instead Apache has an audit trail via SVN, JIRA and signed documents to define the copyright mix on a project.

Minor note to avoid the static import as it makes the code less readable (though Matt and I enjoy arguing on this one :) ). Also not liking all the imports to avoid fully describing in the javadoc. I've not dug far into the code itself. Hoping Matt does :)

> Add more utility methods for generic types
> ------------------------------------------
>
>                 Key: LANG-597
>                 URL: https://issues.apache.org/jira/browse/LANG-597
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.reflect.*
>         Environment: Java 1.5+
>            Reporter: David M. Sledge
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: TypeUtils-Added-Utitlities-Lang-597-2010-03-03.patch
>
>
> Added type utilities include:
> * checking if one type can be assigned to another type
> * determining if a value can be assigned to a given generic type
> * for a class that declares type variables, determining what the type arguments would be based on a generic sub or super type
> * determining if a group of types satisfy the bounds of a group of type variables

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (LANG-597) Add more utility methods for generic types

Posted by "David Sledge (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LANG-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Sledge updated LANG-597:
------------------------------

    Attachment: TypeUtilsTest.java
                TypeUtils.java

Proposed utilities (including a re-factored version of the one already present) and (what I hope are) extensive jUnit tests.

> Add more utility methods for generic types
> ------------------------------------------
>
>                 Key: LANG-597
>                 URL: https://issues.apache.org/jira/browse/LANG-597
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.reflect.*
>         Environment: Java 1.5+
>            Reporter: David Sledge
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: TypeUtils.java, TypeUtilsTest.java
>
>
> Added type utilities include:
> * checking if one type can be assigned to another type
> * determining if a value can be assigned to a given generic variable
> * for a class that declares type variables, determining what the type arguments would be based on a generic sub or super type
> * determining if a group of types satisfy the bounds of a group of type variables

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (LANG-597) Add more utility methods for generic types

Posted by "Matt Benson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LANG-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887977#action_12887977 ] 

Matt Benson commented on LANG-597:
----------------------------------

Note that I did make a few adjustments, e.g. Map return types rather than HashMap, etc.

> Add more utility methods for generic types
> ------------------------------------------
>
>                 Key: LANG-597
>                 URL: https://issues.apache.org/jira/browse/LANG-597
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.reflect.*
>         Environment: Java 1.5+
>            Reporter: David M. Sledge
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: TypeUtils-Added-Utitlities-Lang-597-2010-03-18.patch
>
>
> Added type utilities include:
> * checking if one type can be assigned to another type
> * determining if a value can be assigned to a given generic type
> * for a class that declares type variables, determining what the type arguments would be based on a generic sub or super type
> * determining if a group of types satisfy the bounds of a group of type variables

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (LANG-597) Add more utility methods for generic types

Posted by "Matt Benson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LANG-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840909#action_12840909 ] 

Matt Benson commented on LANG-597:
----------------------------------

{quote}The request seems too trivial to deny.{quote}

That's what *I* thought!

> Add more utility methods for generic types
> ------------------------------------------
>
>                 Key: LANG-597
>                 URL: https://issues.apache.org/jira/browse/LANG-597
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.reflect.*
>         Environment: Java 1.5+
>            Reporter: David Sledge
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: TypeUtils-Added-Utitlities-Lang-597-2010-03-03.patch
>
>
> Added type utilities include:
> * checking if one type can be assigned to another type
> * determining if a value can be assigned to a given generic type
> * for a class that declares type variables, determining what the type arguments would be based on a generic sub or super type
> * determining if a group of types satisfy the bounds of a group of type variables

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (LANG-597) Add more utility methods for generic types

Posted by "David Sledge (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LANG-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Sledge updated LANG-597:
------------------------------

    Attachment: TypeUtils-Added-Utitlities-Lang-597-2010-03-03.patch

First time I've created a patch for any subversion project.  The request seems too trivial to deny.

New patch:  Added @verion and @since tags, removed abstract modifier, and created no-arg default constructor for a JavaBean instance.

> Add more utility methods for generic types
> ------------------------------------------
>
>                 Key: LANG-597
>                 URL: https://issues.apache.org/jira/browse/LANG-597
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.reflect.*
>         Environment: Java 1.5+
>            Reporter: David Sledge
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: TypeUtils-Added-Utitlities-Lang-597-2010-03-03.patch
>
>
> Added type utilities include:
> * checking if one type can be assigned to another type
> * determining if a value can be assigned to a given generic variable
> * for a class that declares type variables, determining what the type arguments would be based on a generic sub or super type
> * determining if a group of types satisfy the bounds of a group of type variables

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (LANG-597) Add more utility methods for generic types

Posted by "Matt Benson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LANG-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840873#action_12840873 ] 

Matt Benson commented on LANG-597:
----------------------------------

Any chance we can have these changes as a patch against trunk without reformatting?  :D Thanks!

> Add more utility methods for generic types
> ------------------------------------------
>
>                 Key: LANG-597
>                 URL: https://issues.apache.org/jira/browse/LANG-597
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.reflect.*
>         Environment: Java 1.5+
>            Reporter: David Sledge
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: TypeUtils.java, TypeUtilsTest.java
>
>
> Added type utilities include:
> * checking if one type can be assigned to another type
> * determining if a value can be assigned to a given generic variable
> * for a class that declares type variables, determining what the type arguments would be based on a generic sub or super type
> * determining if a group of types satisfy the bounds of a group of type variables

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (LANG-597) Add more utility methods for generic types

Posted by "David Sledge (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LANG-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Sledge updated LANG-597:
------------------------------

    Attachment:     (was: TypeUtils.java)

> Add more utility methods for generic types
> ------------------------------------------
>
>                 Key: LANG-597
>                 URL: https://issues.apache.org/jira/browse/LANG-597
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.reflect.*
>         Environment: Java 1.5+
>            Reporter: David Sledge
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: TypeUtils-Added-Utitlities-Lang-597-2010-03-03.patch
>
>
> Added type utilities include:
> * checking if one type can be assigned to another type
> * determining if a value can be assigned to a given generic variable
> * for a class that declares type variables, determining what the type arguments would be based on a generic sub or super type
> * determining if a group of types satisfy the bounds of a group of type variables

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (LANG-597) Add more utility methods for generic types

Posted by "David Sledge (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LANG-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Sledge updated LANG-597:
------------------------------

    Attachment:     (was: TypeUtilsTest.java)

> Add more utility methods for generic types
> ------------------------------------------
>
>                 Key: LANG-597
>                 URL: https://issues.apache.org/jira/browse/LANG-597
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.reflect.*
>         Environment: Java 1.5+
>            Reporter: David Sledge
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: TypeUtils-Added-Utitlities-Lang-597-2010-03-03.patch
>
>
> Added type utilities include:
> * checking if one type can be assigned to another type
> * determining if a value can be assigned to a given generic variable
> * for a class that declares type variables, determining what the type arguments would be based on a generic sub or super type
> * determining if a group of types satisfy the bounds of a group of type variables

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (LANG-597) Add more utility methods for generic types

Posted by "David M. Sledge (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LANG-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David M. Sledge updated LANG-597:
---------------------------------

    Attachment: TypeUtils-Added-Utitlities-Lang-597-2010-03-18.patch

Done, done, and done.  This new patch is against the latest in svn as of 2010-03-18 11:45 am Mountain.

> Add more utility methods for generic types
> ------------------------------------------
>
>                 Key: LANG-597
>                 URL: https://issues.apache.org/jira/browse/LANG-597
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.reflect.*
>         Environment: Java 1.5+
>            Reporter: David M. Sledge
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: TypeUtils-Added-Utitlities-Lang-597-2010-03-18.patch
>
>
> Added type utilities include:
> * checking if one type can be assigned to another type
> * determining if a value can be assigned to a given generic type
> * for a class that declares type variables, determining what the type arguments would be based on a generic sub or super type
> * determining if a group of types satisfy the bounds of a group of type variables

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (LANG-597) Add more utility methods for generic types

Posted by "David Sledge (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LANG-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Sledge updated LANG-597:
------------------------------

    Description: 
Added type utilities include:
* checking if one type can be assigned to another type
* determining if a value can be assigned to a given generic type
* for a class that declares type variables, determining what the type arguments would be based on a generic sub or super type
* determining if a group of types satisfy the bounds of a group of type variables

  was:
Added type utilities include:
* checking if one type can be assigned to another type
* determining if a value can be assigned to a given generic variable
* for a class that declares type variables, determining what the type arguments would be based on a generic sub or super type
* determining if a group of types satisfy the bounds of a group of type variables


> Add more utility methods for generic types
> ------------------------------------------
>
>                 Key: LANG-597
>                 URL: https://issues.apache.org/jira/browse/LANG-597
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.reflect.*
>         Environment: Java 1.5+
>            Reporter: David Sledge
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: TypeUtils-Added-Utitlities-Lang-597-2010-03-03.patch
>
>
> Added type utilities include:
> * checking if one type can be assigned to another type
> * determining if a value can be assigned to a given generic type
> * for a class that declares type variables, determining what the type arguments would be based on a generic sub or super type
> * determining if a group of types satisfy the bounds of a group of type variables

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (LANG-597) Add more utility methods for generic types

Posted by "David M. Sledge (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LANG-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David M. Sledge updated LANG-597:
---------------------------------

    Attachment:     (was: TypeUtils-Added-Utitlities-Lang-597-2010-03-03.patch)

> Add more utility methods for generic types
> ------------------------------------------
>
>                 Key: LANG-597
>                 URL: https://issues.apache.org/jira/browse/LANG-597
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.reflect.*
>         Environment: Java 1.5+
>            Reporter: David M. Sledge
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: TypeUtils-Added-Utitlities-Lang-597-2010-03-18.patch
>
>
> Added type utilities include:
> * checking if one type can be assigned to another type
> * determining if a value can be assigned to a given generic type
> * for a class that declares type variables, determining what the type arguments would be based on a generic sub or super type
> * determining if a group of types satisfy the bounds of a group of type variables

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (LANG-597) Add more utility methods for generic types

Posted by "David Sledge (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LANG-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Sledge updated LANG-597:
------------------------------

    Attachment: TypeUtils-Added-Utitlities-Lang-597-2010-03-03.patch

Patch!  Of course.

> Add more utility methods for generic types
> ------------------------------------------
>
>                 Key: LANG-597
>                 URL: https://issues.apache.org/jira/browse/LANG-597
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.reflect.*
>         Environment: Java 1.5+
>            Reporter: David Sledge
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: TypeUtils-Added-Utitlities-Lang-597-2010-03-03.patch
>
>
> Added type utilities include:
> * checking if one type can be assigned to another type
> * determining if a value can be assigned to a given generic variable
> * for a class that declares type variables, determining what the type arguments would be based on a generic sub or super type
> * determining if a group of types satisfy the bounds of a group of type variables

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (LANG-597) Add more utility methods for generic types

Posted by "David Sledge (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LANG-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Sledge updated LANG-597:
------------------------------

    Attachment:     (was: TypeUtils-Added-Utitlities-Lang-597-2010-03-03.patch)

> Add more utility methods for generic types
> ------------------------------------------
>
>                 Key: LANG-597
>                 URL: https://issues.apache.org/jira/browse/LANG-597
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.reflect.*
>         Environment: Java 1.5+
>            Reporter: David Sledge
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: TypeUtils-Added-Utitlities-Lang-597-2010-03-03.patch
>
>
> Added type utilities include:
> * checking if one type can be assigned to another type
> * determining if a value can be assigned to a given generic variable
> * for a class that declares type variables, determining what the type arguments would be based on a generic sub or super type
> * determining if a group of types satisfy the bounds of a group of type variables

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (LANG-597) Add more utility methods for generic types

Posted by "Matt Benson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LANG-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840888#action_12840888 ] 

Matt Benson commented on LANG-597:
----------------------------------

Thanks for making our job easier--had a guy basically flat-out refuse to provide a patch vs. a straight source file recently...

> Add more utility methods for generic types
> ------------------------------------------
>
>                 Key: LANG-597
>                 URL: https://issues.apache.org/jira/browse/LANG-597
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.reflect.*
>         Environment: Java 1.5+
>            Reporter: David Sledge
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: TypeUtils-Added-Utitlities-Lang-597-2010-03-03.patch
>
>
> Added type utilities include:
> * checking if one type can be assigned to another type
> * determining if a value can be assigned to a given generic variable
> * for a class that declares type variables, determining what the type arguments would be based on a generic sub or super type
> * determining if a group of types satisfy the bounds of a group of type variables

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.