You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/03/31 02:17:09 UTC
[GitHub] [incubator-inlong] dockerzhang commented on a change in pull request #3263: [INLONG-2862][Manager] Support to start Sort tasks through Flink
dockerzhang commented on a change in pull request #3263:
URL: https://github.com/apache/incubator-inlong/pull/3263#discussion_r839108822
##########
File path: inlong-manager/manager-plugins/src/main/java/org/apache/inlong/manager/plugin/flink/Constants.java
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.plugin.flink;
+
+public class Constants {
+
+ public static final String ADDRESS = "flink.rest.address";
+
+ public static final String PORT = "flink.rest.port";
+
+ public static final String JOB_MANAGER_PORT = "flink.jobmanager.port";
+
+ public static final String PARALLELISM = "flink.parallelism";
+
+ public static final String SAVEPOINT_DIRECTORY = "flink.savepoint.directory";
+
+ public static final String SOURCE_INFO = "source_info";
+
+ public static final String SINK_INFO = "sink_info";
+
+ public static final String TYPE = "type";
+
+ public static final String ENTRYPOINT_CLASS = "org.apache.inlong.sort.singletenant.flink.Entrance";
+
+ public static final String INLONG = "INLONG_";
+
+ public static final String SORT_JAR = "sort-single-tenant-1.1.0-incubating-SNAPSHOT.jar";
Review comment:
here should not use the fixed version.
##########
File path: inlong-manager/manager-plugins/pom.xml
##########
@@ -0,0 +1,173 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xmlns="http://maven.apache.org/POM/4.0.0"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.inlong</groupId>
+ <artifactId>inlong-manager</artifactId>
+ <version>1.1.0-incubating-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>manager-plugins</artifactId>
+ <name>Apache InLong - Manager Plugins</name>
+
+ <properties>
+ <project.build.encoding>UTF-8</project.build.encoding>
+ <maven.compiler.source>1.8</maven.compiler.source>
+ <maven.compiler.target>1.8</maven.compiler.target>
+ <lombok.version>1.18.20</lombok.version>
+ <plugin.compile.version>3.8.1</plugin.compile.version>
+ <in.version>1.1.0-incubating-SNAPSHOT</in.version>
+ <junit.version>4.12</junit.version>
+ <commons-io.version>2.11.0</commons-io.version>
+ <flink.version>1.13.5</flink.version>
+ <jackson-core>2.13.1</jackson-core>
+ </properties>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.inlong</groupId>
+ <artifactId>manager-common</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.inlong</groupId>
+ <artifactId>manager-workflow</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.projectlombok</groupId>
+ <artifactId>lombok</artifactId>
+ <version>${lombok.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-clients_2.11</artifactId>
+ <version>${flink.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-core</artifactId>
+ <version>${flink.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson.core</groupId>
+ <artifactId>jackson-core</artifactId>
+ <version>${jackson-core}</version>
+ </dependency>
+ <dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <version>${junit.version}</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.inlong</groupId>
+ <artifactId>manager-client</artifactId>
+ <version>1.1.0-incubating-SNAPSHOT</version>
Review comment:
use <version>${project.version}</version>
##########
File path: inlong-manager/manager-plugins/pom.xml
##########
@@ -0,0 +1,173 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xmlns="http://maven.apache.org/POM/4.0.0"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.inlong</groupId>
+ <artifactId>inlong-manager</artifactId>
+ <version>1.1.0-incubating-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>manager-plugins</artifactId>
+ <name>Apache InLong - Manager Plugins</name>
+
+ <properties>
+ <project.build.encoding>UTF-8</project.build.encoding>
+ <maven.compiler.source>1.8</maven.compiler.source>
+ <maven.compiler.target>1.8</maven.compiler.target>
+ <lombok.version>1.18.20</lombok.version>
+ <plugin.compile.version>3.8.1</plugin.compile.version>
+ <in.version>1.1.0-incubating-SNAPSHOT</in.version>
+ <junit.version>4.12</junit.version>
+ <commons-io.version>2.11.0</commons-io.version>
+ <flink.version>1.13.5</flink.version>
+ <jackson-core>2.13.1</jackson-core>
+ </properties>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.inlong</groupId>
+ <artifactId>manager-common</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.inlong</groupId>
+ <artifactId>manager-workflow</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.projectlombok</groupId>
+ <artifactId>lombok</artifactId>
+ <version>${lombok.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-clients_2.11</artifactId>
+ <version>${flink.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-core</artifactId>
+ <version>${flink.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson.core</groupId>
+ <artifactId>jackson-core</artifactId>
+ <version>${jackson-core}</version>
+ </dependency>
+ <dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <version>${junit.version}</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.inlong</groupId>
+ <artifactId>manager-client</artifactId>
+ <version>1.1.0-incubating-SNAPSHOT</version>
Review comment:
<version>${project.version}</version>
##########
File path: inlong-manager/manager-plugins/src/main/java/org/apache/inlong/manager/plugin/flink/Constants.java
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.plugin.flink;
+
+public class Constants {
+
+ public static final String ADDRESS = "flink.rest.address";
+
+ public static final String PORT = "flink.rest.port";
+
+ public static final String JOB_MANAGER_PORT = "flink.jobmanager.port";
+
+ public static final String PARALLELISM = "flink.parallelism";
+
+ public static final String SAVEPOINT_DIRECTORY = "flink.savepoint.directory";
+
+ public static final String SOURCE_INFO = "source_info";
+
+ public static final String SINK_INFO = "sink_info";
+
+ public static final String TYPE = "type";
+
+ public static final String ENTRYPOINT_CLASS = "org.apache.inlong.sort.singletenant.flink.Entrance";
+
+ public static final String INLONG = "INLONG_";
+
+ public static final String SORT_JAR = "sort-single-tenant-1.1.0-incubating-SNAPSHOT.jar";
Review comment:
fixed version is not good.
##########
File path: inlong-manager/manager-plugins/pom.xml
##########
@@ -0,0 +1,173 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xmlns="http://maven.apache.org/POM/4.0.0"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.inlong</groupId>
+ <artifactId>inlong-manager</artifactId>
+ <version>1.1.0-incubating-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>manager-plugins</artifactId>
+ <name>Apache InLong - Manager Plugins</name>
+
+ <properties>
+ <project.build.encoding>UTF-8</project.build.encoding>
+ <maven.compiler.source>1.8</maven.compiler.source>
+ <maven.compiler.target>1.8</maven.compiler.target>
+ <lombok.version>1.18.20</lombok.version>
+ <plugin.compile.version>3.8.1</plugin.compile.version>
+ <in.version>1.1.0-incubating-SNAPSHOT</in.version>
Review comment:
useless, remove this version.
##########
File path: inlong-manager/manager-plugins/pom.xml
##########
@@ -0,0 +1,173 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xmlns="http://maven.apache.org/POM/4.0.0"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.inlong</groupId>
+ <artifactId>inlong-manager</artifactId>
+ <version>1.1.0-incubating-SNAPSHOT</version>
+ </parent>
+
+ <artifactId>manager-plugins</artifactId>
+ <name>Apache InLong - Manager Plugins</name>
+
+ <properties>
+ <project.build.encoding>UTF-8</project.build.encoding>
+ <maven.compiler.source>1.8</maven.compiler.source>
+ <maven.compiler.target>1.8</maven.compiler.target>
+ <lombok.version>1.18.20</lombok.version>
+ <plugin.compile.version>3.8.1</plugin.compile.version>
+ <in.version>1.1.0-incubating-SNAPSHOT</in.version>
Review comment:
this line is useless.
##########
File path: inlong-manager/manager-plugins/src/main/assembly/package.xml
##########
@@ -0,0 +1,44 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review comment:
can we reuse the assembly.xml in manager-web？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org