You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by to...@apache.org on 2022/05/29 14:29:11 UTC

[shardingsphere] branch master updated: Update SchemaMetaDataLoaderAdvice to MetaDataContextsBuilderAdvice. (#18048)

This is an automated email from the ASF dual-hosted git repository.

totalo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new ea76be9e62a Update SchemaMetaDataLoaderAdvice to MetaDataContextsBuilderAdvice. (#18048)
ea76be9e62a is described below

commit ea76be9e62a3e48429afeff7d64881ba3e24b9ed
Author: Raigor <ra...@gmail.com>
AuthorDate: Sun May 29 22:29:05 2022 +0800

    Update SchemaMetaDataLoaderAdvice to MetaDataContextsBuilderAdvice. (#18048)
---
 ...MetaDataLoaderAdvice.java => MetaDataContextsBuilderAdvice.java} | 5 ++---
 .../logging/base/definition/BaseLoggingPluginDefinitionService.java | 6 +++---
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-logging/shardingsphere-agent-logging-base/src/main/java/org/apache/shardingsphere/agent/plugin/logging/base/advice/SchemaMetaDataLoaderAdvice.java b/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-logging/shardingsphere-agent-logging-base/src/main/java/org/apache/shardingsphere/agent/plugin/logging/base/advice/MetaDataContextsBuilderAdvice.java
similarity index 88%
rename from shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-logging/shardingsphere-agent-logging-base/src/main/java/org/apache/shardingsphere/agent/plugin/logging/base/advice/SchemaMetaDataLoaderAdvice.java
rename to shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-logging/shardingsphere-agent-logging-base/src/main/java/org/apache/shardingsphere/agent/plugin/logging/base/advice/MetaDataContextsBuilderAdvice.java
index abcbbe15d7f..5d06c3c1133 100644
--- a/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-logging/shardingsphere-agent-logging-base/src/main/java/org/apache/shardingsphere/agent/plugin/logging/base/advice/SchemaMetaDataLoaderAdvice.java
+++ b/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-logging/shardingsphere-agent-logging-base/src/main/java/org/apache/shardingsphere/agent/plugin/logging/base/advice/MetaDataContextsBuilderAdvice.java
@@ -29,7 +29,7 @@ import java.lang.reflect.Method;
  * Schema meta data loader advice.
  */
 @Slf4j
-public final class SchemaMetaDataLoaderAdvice implements InstanceMethodAroundAdvice {
+public final class MetaDataContextsBuilderAdvice implements InstanceMethodAroundAdvice {
     
     @Override
     public void beforeMethod(final AdviceTargetObject target, final Method method, final Object[] args, final MethodInvocationResult result) {
@@ -39,9 +39,8 @@ public final class SchemaMetaDataLoaderAdvice implements InstanceMethodAroundAdv
     @Override
     public void afterMethod(final AdviceTargetObject target, final Method method, final Object[] args, final MethodInvocationResult result) {
         try {
-            String schemaName = (String) args[0];
             long elapsedTime = System.currentTimeMillis() - ElapsedTimeThreadLocal.INSTANCE.get();
-            log.info("Load meta data for schema {} finished, cost {} milliseconds", schemaName, elapsedTime);
+            log.info("Build meta data contexts finished, cost {} milliseconds", elapsedTime);
         } finally {
             ElapsedTimeThreadLocal.INSTANCE.remove();
         }
diff --git a/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-logging/shardingsphere-agent-logging-base/src/main/java/org/apache/shardingsphere/agent/plugin/logging/base/definition/BaseLoggingPluginDefinitionService.java b/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-logging/shardingsphere-agent-logging-base/src/main/java/org/apache/shardingsphere/agent/plugin/logging/base/definition/BaseLoggingPluginDefinitionService.java
index f2d40609e46..abad4721d35 100644
--- a/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-logging/shardingsphere-agent-logging-base/src/main/java/org/apache/shardingsphere/agent/plugin/logging/base/definition/BaseLoggingPluginDefinitionService.java
+++ b/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-logging/shardingsphere-agent-logging-base/src/main/java/org/apache/shardingsphere/agent/plugin/logging/base/definition/BaseLoggingPluginDefinitionService.java
@@ -25,11 +25,11 @@ import org.apache.shardingsphere.agent.spi.definition.AbstractPluginDefinitionSe
  */
 public final class BaseLoggingPluginDefinitionService extends AbstractPluginDefinitionService {
     
-    private static final String SCHEMA_METADATA_LOADER_CLASS = "org.apache.shardingsphere.infra.context.metadata.MetaDataContextsBuilder";
+    private static final String SCHEMA_METADATA_LOADER_CLASS = "org.apache.shardingsphere.mode.metadata.MetaDataContextsBuilder";
     
-    private static final String SCHEMA_METADATA_LOADER_METHOD_NAME = "buildMetaData";
+    private static final String SCHEMA_METADATA_LOADER_METHOD_NAME = "build";
     
-    private static final String SCHEMA_METADATA_LOADER_ADVICE_CLASS = "org.apache.shardingsphere.agent.plugin.logging.base.advice.SchemaMetaDataLoaderAdvice";
+    private static final String SCHEMA_METADATA_LOADER_ADVICE_CLASS = "org.apache.shardingsphere.agent.plugin.logging.base.advice.MetaDataContextsBuilderAdvice";
     
     @Override
     public void defineInterceptors() {