[GitHub] [incubator-gobblin] arjun4084346 commented on a change in pull request #2993: [GOBBLIN-1154] Improve gaas error messages

[GitBox <gi...@apache.org>]

arjun4084346 commented on a change in pull request #2993:
URL: https://github.com/apache/incubator-gobblin/pull/2993#discussion_r428528095



##########
File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/TimingEventUtils.java
##########
@@ -26,6 +26,7 @@
 import org.apache.gobblin.runtime.api.FlowSpec;
 import org.apache.gobblin.runtime.api.JobSpec;
 import org.apache.gobblin.runtime.api.SpecExecutor;
+import org.apache.gobblin.service.modules.flowgraph.Dag;

Review comment:
       unused import

##########
File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
##########
@@ -476,6 +476,9 @@ private void cancelDag(String dagToCancel) throws ExecutionException, Interrupte
         for (DagNode<JobExecutionPlan> dagNodeToCancel : dagNodesToCancel) {
           cancelDagNode(dagNodeToCancel);
         }
+
+        this.dags.get(dagToCancel).setFlowEvent(TimingEvent.FlowTimings.FLOW_CANCELLED);

Review comment:
       Should we setFlowEvent() inside cancelDagNode() ?

##########
File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java
##########
@@ -259,6 +259,7 @@ public void orchestrate(Spec spec) throws Exception {
         // In this case, the current time is used as the flow executionId.
         flowMetadata.putIfAbsent(TimingEvent.FlowEventConstants.FLOW_EXECUTION_ID_FIELD,
             Long.toString(System.currentTimeMillis()));
+        flowMetadata.put(TimingEvent.METADATA_MESSAGE, "Flow compilation failed");

Review comment:
       Can we add spec.getCompilationErrors() also? We will know which execution failed with which config exception.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org