[jira] [Commented] (PHOENIX-6078) Remove Internal Phoenix Connections from parent LinkedQueue when closed

["Hadoop QA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-6078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17178454#comment-17178454 ] 

Hadoop QA commented on PHOENIX-6078:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/13009944/PHOENIX-6078.4.x.patch
  against 4.x branch at commit .
  ATTACHMENT ID: 13009944

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 4 release audit warnings (more than the master's current 0 warnings).

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.PartialResultServerConfigurationIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.NullIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsExtendedIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.PhoenixRuntimeIT

Test results: https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/22//testReport/
Code Coverage results: https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/22//artifact/phoenix-core/target/site/jacoco/index.html
Release audit warnings: https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/22//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/22//console

This message is automatically generated.

> Remove Internal Phoenix Connections from parent LinkedQueue when closed
> -----------------------------------------------------------------------
>
>                 Key: PHOENIX-6078
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6078
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.14.3, 4.x
>            Reporter: Saksham Gangwar
>            Assignee: Saksham Gangwar
>            Priority: Major
>             Fix For: 4.16.0
>
>         Attachments: PHOENIX-6078.4.x.patch, PHOENIX-6078.4.x.patch
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> In https://issues.apache.org/jira/browse/PHOENIX-5872
> We started maintaining parent-child relationships between phoenix connections to close those connections. But after closing those child connections we should be removing them from the Queue which is being maintained for the same.
> Here:
> [https://github.com/apache/phoenix/blob/affa9e889efcc2ad7dac009a0d294b09447d281e/phoenix-core/src/main/java/org/apache/phoenix/compile/MutatingParallelIteratorFactory.java#L114]
>  
> If not removed from the queue, and if the parent connection is being reused: we are observing the OOM issue on the container side during the mapper run.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)