You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/11/26 15:13:45 UTC
[GitHub] [hudi] nsivabalan opened a new pull request #4132: [MINOR] Fixing test failure to fix CI build failure
nsivabalan opened a new pull request #4132:
URL: https://github.com/apache/hudi/pull/4132
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4132: [MINOR] Fixing test failure to fix CI build failure
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4132:
URL: https://github.com/apache/hudi/pull/4132#issuecomment-980199885
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "02aab597acffb3082bc56b27f8bc356f268d0a41",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3802",
"triggerID" : "02aab597acffb3082bc56b27f8bc356f268d0a41",
"triggerType" : "PUSH"
}, {
"hash" : "db253f0c38d1b9046a6cf685d0a439a3814edd6d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3805",
"triggerID" : "db253f0c38d1b9046a6cf685d0a439a3814edd6d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* db253f0c38d1b9046a6cf685d0a439a3814edd6d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3805)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4132: [MINOR] Fixing test failure to fix CI build failure
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4132:
URL: https://github.com/apache/hudi/pull/4132#issuecomment-980051934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "02aab597acffb3082bc56b27f8bc356f268d0a41",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "02aab597acffb3082bc56b27f8bc356f268d0a41",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 02aab597acffb3082bc56b27f8bc356f268d0a41 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4132: [MINOR] Fixing test failure to fix CI build failure
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4132:
URL: https://github.com/apache/hudi/pull/4132#issuecomment-980065165
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "02aab597acffb3082bc56b27f8bc356f268d0a41",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3802",
"triggerID" : "02aab597acffb3082bc56b27f8bc356f268d0a41",
"triggerType" : "PUSH"
}, {
"hash" : "db253f0c38d1b9046a6cf685d0a439a3814edd6d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db253f0c38d1b9046a6cf685d0a439a3814edd6d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 02aab597acffb3082bc56b27f8bc356f268d0a41 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3802)
* db253f0c38d1b9046a6cf685d0a439a3814edd6d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4132: [MINOR] Fixing test failure to fix CI build failure
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4132:
URL: https://github.com/apache/hudi/pull/4132#issuecomment-980065165
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "02aab597acffb3082bc56b27f8bc356f268d0a41",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3802",
"triggerID" : "02aab597acffb3082bc56b27f8bc356f268d0a41",
"triggerType" : "PUSH"
}, {
"hash" : "db253f0c38d1b9046a6cf685d0a439a3814edd6d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db253f0c38d1b9046a6cf685d0a439a3814edd6d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 02aab597acffb3082bc56b27f8bc356f268d0a41 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3802)
* db253f0c38d1b9046a6cf685d0a439a3814edd6d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4132: [MINOR] Fixing test failure to fix CI build failure
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4132:
URL: https://github.com/apache/hudi/pull/4132#issuecomment-980051934
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "02aab597acffb3082bc56b27f8bc356f268d0a41",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "02aab597acffb3082bc56b27f8bc356f268d0a41",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 02aab597acffb3082bc56b27f8bc356f268d0a41 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #4132: [MINOR] Fixing test failure to fix CI build failure
Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #4132:
URL: https://github.com/apache/hudi/pull/4132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4132: [MINOR] Fixing test failure to fix CI build failure
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4132:
URL: https://github.com/apache/hudi/pull/4132#issuecomment-980053438
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "02aab597acffb3082bc56b27f8bc356f268d0a41",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3802",
"triggerID" : "02aab597acffb3082bc56b27f8bc356f268d0a41",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 02aab597acffb3082bc56b27f8bc356f268d0a41 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3802)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4132: [MINOR] Fixing test failure to fix CI build failure
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4132:
URL: https://github.com/apache/hudi/pull/4132#issuecomment-980097622
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "02aab597acffb3082bc56b27f8bc356f268d0a41",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3802",
"triggerID" : "02aab597acffb3082bc56b27f8bc356f268d0a41",
"triggerType" : "PUSH"
}, {
"hash" : "db253f0c38d1b9046a6cf685d0a439a3814edd6d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3805",
"triggerID" : "db253f0c38d1b9046a6cf685d0a439a3814edd6d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 02aab597acffb3082bc56b27f8bc356f268d0a41 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3802)
* db253f0c38d1b9046a6cf685d0a439a3814edd6d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3805)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4132: [MINOR] Fixing test failure to fix CI build failure
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4132:
URL: https://github.com/apache/hudi/pull/4132#issuecomment-980053438
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "02aab597acffb3082bc56b27f8bc356f268d0a41",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3802",
"triggerID" : "02aab597acffb3082bc56b27f8bc356f268d0a41",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 02aab597acffb3082bc56b27f8bc356f268d0a41 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3802)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4132: [MINOR] Fixing test failure to fix CI build failure
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4132:
URL: https://github.com/apache/hudi/pull/4132#issuecomment-980097622
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "02aab597acffb3082bc56b27f8bc356f268d0a41",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3802",
"triggerID" : "02aab597acffb3082bc56b27f8bc356f268d0a41",
"triggerType" : "PUSH"
}, {
"hash" : "db253f0c38d1b9046a6cf685d0a439a3814edd6d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3805",
"triggerID" : "db253f0c38d1b9046a6cf685d0a439a3814edd6d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 02aab597acffb3082bc56b27f8bc356f268d0a41 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3802)
* db253f0c38d1b9046a6cf685d0a439a3814edd6d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3805)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4132: [MINOR] Fixing test failure to fix CI build failure
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4132:
URL: https://github.com/apache/hudi/pull/4132#issuecomment-980063798
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "02aab597acffb3082bc56b27f8bc356f268d0a41",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3802",
"triggerID" : "02aab597acffb3082bc56b27f8bc356f268d0a41",
"triggerType" : "PUSH"
}, {
"hash" : "db253f0c38d1b9046a6cf685d0a439a3814edd6d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db253f0c38d1b9046a6cf685d0a439a3814edd6d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 02aab597acffb3082bc56b27f8bc356f268d0a41 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3802)
* db253f0c38d1b9046a6cf685d0a439a3814edd6d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4132: [MINOR] Fixing test failure to fix CI build failure
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4132:
URL: https://github.com/apache/hudi/pull/4132#issuecomment-980063798
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "02aab597acffb3082bc56b27f8bc356f268d0a41",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3802",
"triggerID" : "02aab597acffb3082bc56b27f8bc356f268d0a41",
"triggerType" : "PUSH"
}, {
"hash" : "db253f0c38d1b9046a6cf685d0a439a3814edd6d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "db253f0c38d1b9046a6cf685d0a439a3814edd6d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 02aab597acffb3082bc56b27f8bc356f268d0a41 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3802)
* db253f0c38d1b9046a6cf685d0a439a3814edd6d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a change in pull request #4132: [MINOR] Fixing test failure to fix CI build failure
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #4132:
URL: https://github.com/apache/hudi/pull/4132#discussion_r757592369
##########
File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/TestHoodieClientMultiWriter.java
##########
@@ -345,16 +344,16 @@ public void testHoodieClientMultiWriterWithClustering(HoodieTableType tableType)
numRecords, 200, 2);
// Start and finish another commit while the previous writer for commit 003 is running
newCommitTime = "004";
- SparkRDDWriteClient client2 = getHoodieWriteClient(cfg2);
+ SparkRDDWriteClient client2 = getHoodieWriteClient(cfg);
JavaRDD<WriteStatus> result2 = updateBatch(cfg2, client2, newCommitTime, "001",
Option.of(Arrays.asList(commitTimeBetweenPrevAndNew)), "000", numRecords, SparkRDDWriteClient::upsert, false, false,
numRecords, 200, 2);
client2.commit(newCommitTime, result2);
// Schedule and run clustering while previous writer for commit 003 is running
- SparkRDDWriteClient client3 = getHoodieWriteClient(cfg);
+ SparkRDDWriteClient client3 = getHoodieWriteClient(cfg2);
// schedule clustering
Option<String> clusterInstant = client3.scheduleTableService(Option.empty(), TableServiceType.CLUSTER);
- assertFalse(clusterInstant.isPresent());
+ assertTrue(clusterInstant.isPresent());
Review comment:
NTR: first two clients makes 2 commits and 1 inflight commit(003). and 3rd client which has inline clustering config enabled, tries to schedule clustering. So, it should be true here. following this, when we try to commit 003, we expect it to fail due to conflicts. So, don't understand why this was set to false before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org