You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/10 16:11:31 UTC

[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request #4229: Move process text and quote character from segment details to IdentifierValue

terrymanu opened a new pull request #4229: Move process text and quote character from segment details to IdentifierValue
URL: https://github.com/apache/incubator-shardingsphere/pull/4229
 
 
   For #3914.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4229: Move process text and quote character from segment details to IdentifierValue

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4229: Move process text and quote character from segment details to IdentifierValue
URL: https://github.com/apache/incubator-shardingsphere/pull/4229#issuecomment-584224825
 
 
   ## Pull Request Test Coverage Report for [Build 1674](https://coveralls.io/builds/28635639)
   
   * **2** of **35**   **(5.71%)**  changed or added relevant lines in **10** files are covered.
   * **3** unchanged lines in **3** files lost coverage.
   * Overall coverage decreased (**-0.08%**) to **64.705%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/segment/dml/item/ColumnProjectionSegment.java](https://coveralls.io/builds/28635639/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fsegment%2Fdml%2Fitem%2FColumnProjectionSegment.java#L40) | 0 | 1 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/common/schema/SchemaExtractor.java](https://coveralls.io/builds/28635639/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2Fimpl%2Fcommon%2Fschema%2FSchemaExtractor.java#L41) | 2 | 4 | 50.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/dml/select/item/impl/ShorthandProjectionExtractor.java](https://coveralls.io/builds/28635639/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2Fimpl%2Fdml%2Fselect%2Fitem%2Fimpl%2FShorthandProjectionExtractor.java#L50) | 0 | 2 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDALVisitor.java](https://coveralls.io/builds/28635639/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDALVisitor.java#L139) | 0 | 2 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDMLVisitor.java](https://coveralls.io/builds/28635639/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDMLVisitor.java#L351) | 0 | 3 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/common/column/ColumnExtractor.java](https://coveralls.io/builds/28635639/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2Fimpl%2Fcommon%2Fcolumn%2FColumnExtractor.java#L47) | 0 | 4 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/common/index/IndexExtractor.java](https://coveralls.io/builds/28635639/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2Fimpl%2Fcommon%2Findex%2FIndexExtractor.java#L40) | 0 | 4 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/common/table/TableExtractor.java](https://coveralls.io/builds/28635639/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2Fimpl%2Fcommon%2Ftable%2FTableExtractor.java#L52) | 0 | 4 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/value/identifier/IdentifierValue.java](https://coveralls.io/builds/28635639/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fvalue%2Fidentifier%2FIdentifierValue.java#L37) | 0 | 4 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/MySQLVisitor.java](https://coveralls.io/builds/28635639/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FMySQLVisitor.java#L204) | 0 | 7 | 0.0%
   <!-- | **Total:** | **2** | **35** | **5.71%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/dml/select/item/impl/ShorthandProjectionExtractor.java](https://coveralls.io/builds/28635639/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2Fimpl%2Fdml%2Fselect%2Fitem%2Fimpl%2FShorthandProjectionExtractor.java#L52) | 1 | 7.14% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDALVisitor.java](https://coveralls.io/builds/28635639/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDALVisitor.java#L141) | 1 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDMLVisitor.java](https://coveralls.io/builds/28635639/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDMLVisitor.java#L354) | 1 | 0% |
   <!-- | **Total:** | **3** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28635639/badge)](https://coveralls.io/builds/28635639) |
   | :-- | --: |
   | Change from base [Build 813](https://coveralls.io/builds/28632923): |  -0.08% |
   | Covered Lines: | 11016 |
   | Relevant Lines: | 17025 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4229: Move process text and quote character from segment details to IdentifierValue

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4229: Move process text and quote character from segment details to IdentifierValue
URL: https://github.com/apache/incubator-shardingsphere/pull/4229#issuecomment-584228152
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229?src=pr&el=h1) Report
   > Merging [#4229](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/ecf08f90f690d3e284001e8305aa864481d66c3f?src=pr&el=desc) will **increase** coverage by `0.22%`.
   > The diff coverage is `2.85%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229/graphs/tree.svg?width=650&token=ZvlXpWa7so&height=150&src=pr)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##             master   #4229      +/-   ##
   ===========================================
   + Coverage     60.57%   60.8%   +0.22%     
     Complexity      352     352              
   ===========================================
     Files          1015    1012       -3     
     Lines         17000   17025      +25     
     Branches       3001    3004       +3     
   ===========================================
   + Hits          10298   10352      +54     
   + Misses         6050    6020      -30     
   - Partials        652     653       +1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...e/sql/parser/sql/segment/generic/TableSegment.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9nZW5lcmljL1RhYmxlU2VnbWVudC5qYXZh) | `28.57% <ø> (-32.97%)` | `1 <0> (ø)` | |
   | [...l/parser/sql/segment/dml/column/ColumnSegment.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9kbWwvY29sdW1uL0NvbHVtblNlZ21lbnQuamF2YQ==) | `50% <ø> (-37.5%)` | `0 <0> (ø)` | |
   | [...re/extractor/impl/common/index/IndexExtractor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL2V4dHJhY3Rvci9pbXBsL2NvbW1vbi9pbmRleC9JbmRleEV4dHJhY3Rvci5qYXZh) | `16.66% <0%> (-8.34%)` | `1 <0> (ø)` | |
   | [...select/item/impl/ShorthandProjectionExtractor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL2V4dHJhY3Rvci9pbXBsL2RtbC9zZWxlY3QvaXRlbS9pbXBsL1Nob3J0aGFuZFByb2plY3Rpb25FeHRyYWN0b3IuamF2YQ==) | `7.14% <0%> (-0.55%)` | `1 <0> (ø)` | |
   | [...re/extractor/impl/common/table/TableExtractor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL2V4dHJhY3Rvci9pbXBsL2NvbW1vbi90YWJsZS9UYWJsZUV4dHJhY3Rvci5qYXZh) | `5.26% <0%> (-0.62%)` | `1 <0> (ø)` | |
   | [...l/parser/sql/value/identifier/IdentifierValue.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvdmFsdWUvaWRlbnRpZmllci9JZGVudGlmaWVyVmFsdWUuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...apache/shardingsphere/sql/parser/MySQLVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL015U1FMVmlzaXRvci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../sql/segment/dml/item/ColumnProjectionSegment.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvc2VnbWVudC9kbWwvaXRlbS9Db2x1bW5Qcm9qZWN0aW9uU2VnbWVudC5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../extractor/impl/common/column/ColumnExtractor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL2V4dHJhY3Rvci9pbXBsL2NvbW1vbi9jb2x1bW4vQ29sdW1uRXh0cmFjdG9yLmphdmE=) | `9.09% <0%> (-2.03%)` | `1 <0> (ø)` | |
   | [...dingsphere/sql/parser/visitor/MySQLDALVisitor.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLW15c3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3Zpc2l0b3IvTXlTUUxEQUxWaXNpdG9yLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | ... and [71 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229?src=pr&el=footer). Last update [ecf08f9...e2b7c15](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4229?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4229: Move process text and quote character from segment details to IdentifierValue

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4229: Move process text and quote character from segment details to IdentifierValue
URL: https://github.com/apache/incubator-shardingsphere/pull/4229#issuecomment-584224825
 
 
   ## Pull Request Test Coverage Report for [Build 9432](https://coveralls.io/builds/28635998)
   
   * **2** of **35**   **(5.71%)**  changed or added relevant lines in **10** files are covered.
   * **6** unchanged lines in **4** files lost coverage.
   * Overall coverage decreased (**-0.09%**) to **64.699%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/segment/dml/item/ColumnProjectionSegment.java](https://coveralls.io/builds/28635998/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fsegment%2Fdml%2Fitem%2FColumnProjectionSegment.java#L40) | 0 | 1 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/common/schema/SchemaExtractor.java](https://coveralls.io/builds/28635998/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2Fimpl%2Fcommon%2Fschema%2FSchemaExtractor.java#L41) | 2 | 4 | 50.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/dml/select/item/impl/ShorthandProjectionExtractor.java](https://coveralls.io/builds/28635998/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2Fimpl%2Fdml%2Fselect%2Fitem%2Fimpl%2FShorthandProjectionExtractor.java#L50) | 0 | 2 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDALVisitor.java](https://coveralls.io/builds/28635998/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDALVisitor.java#L139) | 0 | 2 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDMLVisitor.java](https://coveralls.io/builds/28635998/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDMLVisitor.java#L351) | 0 | 3 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/common/column/ColumnExtractor.java](https://coveralls.io/builds/28635998/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2Fimpl%2Fcommon%2Fcolumn%2FColumnExtractor.java#L47) | 0 | 4 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/common/index/IndexExtractor.java](https://coveralls.io/builds/28635998/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2Fimpl%2Fcommon%2Findex%2FIndexExtractor.java#L40) | 0 | 4 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/common/table/TableExtractor.java](https://coveralls.io/builds/28635998/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2Fimpl%2Fcommon%2Ftable%2FTableExtractor.java#L52) | 0 | 4 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/value/identifier/IdentifierValue.java](https://coveralls.io/builds/28635998/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fvalue%2Fidentifier%2FIdentifierValue.java#L37) | 0 | 4 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/MySQLVisitor.java](https://coveralls.io/builds/28635998/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FMySQLVisitor.java#L204) | 0 | 7 | 0.0%
   <!-- | **Total:** | **2** | **35** | **5.71%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/dml/select/item/impl/ShorthandProjectionExtractor.java](https://coveralls.io/builds/28635998/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2Fimpl%2Fdml%2Fselect%2Fitem%2Fimpl%2FShorthandProjectionExtractor.java#L52) | 1 | 7.14% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDALVisitor.java](https://coveralls.io/builds/28635998/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDALVisitor.java#L141) | 1 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDMLVisitor.java](https://coveralls.io/builds/28635998/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDMLVisitor.java#L354) | 1 | 0% |
   | [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28635998/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L65) | 3 | 76.0% |
   <!-- | **Total:** | **6** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28635998/badge)](https://coveralls.io/builds/28635998) |
   | :-- | --: |
   | Change from base [Build 813](https://coveralls.io/builds/28632923): |  -0.09% |
   | Covered Lines: | 11015 |
   | Relevant Lines: | 17025 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4229: Move process text and quote character from segment details to IdentifierValue

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #4229: Move process text and quote character from segment details to IdentifierValue
URL: https://github.com/apache/incubator-shardingsphere/pull/4229
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services