[jira] [Commented] (MNG-7316) MavenProject.getAttachedArtifacts() regression with 3.8.1

["Michael Osipov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MNG-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433368#comment-17433368 ] 

Michael Osipov commented on MNG-7316:
-------------------------------------

...interesting. Why are you attaching and then detaching artifacts?
The fix was done on purpose and the API does not describe.
[~olamy], [~khmarbaise].

Even if I revert this, this would retain in 4 because it would add still the option to add the same artifact multiple times.

> MavenProject.getAttachedArtifacts() regression with 3.8.1
> ---------------------------------------------------------
>
>                 Key: MNG-7316
>                 URL: https://issues.apache.org/jira/browse/MNG-7316
>             Project: Maven
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 3.8.2, 3.8.3
>            Reporter: Gary D. Gregory
>            Priority: Critical
>
> The method {{MavenProject.getAttachedArtifacts()}} as of 3.8.2 breaks releasing components for us at Apache Commons using our Maven Release plugin because the list returned is now immutable, we now get an exception when calling {{remove()}} on the collection returned by the API; see [https://github.com/apache/commons-release-plugin/blob/master/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionDetachmentMojo.java#L137]
> This worked fine in 3.8.1, may you please change it back for 3.8.4?
> We cannot use Maven 3.8.2 and 3.8.3 to release our components.
> ([~michael-o]: Ironically, I discovered this trying to create a release candidate for Apache Commons CLI.)
> The exception in 3.8.3:
> {quote}Caused by: java.lang.UnsupportedOperationException
>  at java.util.Collections$UnmodifiableCollection.remove (Collections.java:1060)
>  at org.apache.commons.release.plugin.mojos.CommonsDistributionDetachmentMojo.execute (CommonsDistributionDetachmentMojo.java:136)
>  at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
> {quote}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)