You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/14 13:32:32 UTC
[GitHub] [flink] dianfu commented on a change in pull request #10995:
[FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
dianfu commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#discussion_r379294175
##########
File path: flink-dist/src/main/assemblies/opt.xml
##########
@@ -168,6 +168,14 @@
<destName>flink-python_${scala.binary.version}-${project.version}.jar</destName>
<fileMode>0644</fileMode>
</file>
+
+ <!-- ML (API & LIB) -->
+ <file>
Review comment:
Should we add a module "flink-ml-uber" just like "flink-table-uber" to create a fat job for flink ml module? Currently it assumes that the flink-ml-api is packaged in the fat jar of flink-ml-lib. This seems a little wired for me. It would be great if more people could share the thoughts on this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services