You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/09 10:24:20 UTC
[GitHub] [incubator-nuttx] pussuw opened a new pull request, #6818: risc-v: Implement riscv_sbi_set_timer
pussuw opened a new pull request, #6818:
URL: https://github.com/apache/incubator-nuttx/pull/6818
This implements riscv_sbi_set_timer. This requires the OpenSBI companion
software to work (but this is needed by the kernel mode anyways).
## Summary
Implements the missing functionality in riscv_sbi_set_timer.
## Impact
M-Timer works now, uses OpenSBI as interface
## Testing
icicle:knsh + OpenSBI v1.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6818: risc-v: Implement riscv_sbi_set_timer
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6818:
URL: https://github.com/apache/incubator-nuttx/pull/6818
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6818: risc-v: Implement riscv_sbi_set_timer
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6818:
URL: https://github.com/apache/incubator-nuttx/pull/6818#discussion_r941469930
##########
arch/risc-v/src/common/supervisor/riscv_sbi.c:
##########
@@ -33,24 +45,30 @@
* Private Functions
****************************************************************************/
-#ifdef CONFIG_ARCH_RV64
-static inline uint64_t rdtime(void)
+static inline uintptr_t sbi_ecall(unsigned int extid, unsigned int fid,
Review Comment:
should we move the general sbi_ecall to riscv_internal.h like sys_call0 etc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6818: risc-v: Implement riscv_sbi_set_timer
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6818:
URL: https://github.com/apache/incubator-nuttx/pull/6818#discussion_r941469930
##########
arch/risc-v/src/common/supervisor/riscv_sbi.c:
##########
@@ -33,24 +45,30 @@
* Private Functions
****************************************************************************/
-#ifdef CONFIG_ARCH_RV64
-static inline uint64_t rdtime(void)
+static inline uintptr_t sbi_ecall(unsigned int extid, unsigned int fid,
Review Comment:
should we move the general sbi_ecall to riscv_internal.h?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6818: risc-v: Implement riscv_sbi_set_timer
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6818:
URL: https://github.com/apache/incubator-nuttx/pull/6818#discussion_r941648426
##########
arch/risc-v/src/common/supervisor/riscv_sbi.c:
##########
@@ -33,24 +45,30 @@
* Private Functions
****************************************************************************/
-#ifdef CONFIG_ARCH_RV64
-static inline uint64_t rdtime(void)
+static inline uintptr_t sbi_ecall(unsigned int extid, unsigned int fid,
Review Comment:
Ok, let's merge this version first until we found the need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6818: risc-v: Implement riscv_sbi_set_timer
Posted by GitBox <gi...@apache.org>.
pussuw commented on code in PR #6818:
URL: https://github.com/apache/incubator-nuttx/pull/6818#discussion_r941544577
##########
arch/risc-v/src/common/supervisor/riscv_sbi.c:
##########
@@ -33,24 +45,30 @@
* Private Functions
****************************************************************************/
-#ifdef CONFIG_ARCH_RV64
-static inline uint64_t rdtime(void)
+static inline uintptr_t sbi_ecall(unsigned int extid, unsigned int fid,
Review Comment:
Sure it can be done. Do you anticipate the definition will be needed by other source files ? My original idea was to put all SBI calls in this file but I don't know if e.g. OpenAMP or some IPI-interface etc. will need this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org