[jira] Work logged: (SHIRO-109) RememberMeManager should have access to Subject context map

["Les Hazlewood (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SHIRO-109?page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#action_11006 ]

Les Hazlewood logged work on SHIRO-109:
---------------------------------------

                Author: Les Hazlewood
            Created on: 11/Feb/10 10:02 PM
            Start Date: 11/Feb/10 09:59 PM
    Worklog Time Spent: 3h 
      Work Description: Changed the RememberMeManager API to accept the subject context map as well as Subject instances where necessary.  JavaDoc'd RememberMeManager interface and all of AbstractRememberMeManager.

Issue Time Tracking
-------------------

            Time Spent: 3h
    Remaining Estimate: 0h

> RememberMeManager should have access to Subject context map
> -----------------------------------------------------------
>
>                 Key: SHIRO-109
>                 URL: https://issues.apache.org/jira/browse/SHIRO-109
>             Project: Shiro
>          Issue Type: Improvement
>          Components: Subject, Web
>    Affects Versions: 0.9-RC1, 0.9
>            Reporter: Les Hazlewood
>            Assignee: Les Hazlewood
>             Fix For: 1.0.0
>
>          Time Spent: 3h
>  Remaining Estimate: 0h
>
> A bug surfacing in the ShiroFilter showed that WebUtils.bind* methods needed to be called before the WebSubject.Builder could be used.  This is because the RememberMeManager does not accept a Subject context map from where it could receive the Request and Response objects, so it must look them up from the thread, which surfaces the fragility of assumptions made about the thread.
> Instead, the subject creation context map should be given to the RememberMeManager so it can use whatever it needs inside the map to use to lookup the identity if necessary.
> See http://www.mail-archive.com/shiro-dev@incubator.apache.org/msg00178.html for details.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.