You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2020/03/06 01:37:41 UTC

[kudu-CR] util: remove all gscoped ptr

Hello Alexey Serbin, Andrew Wong,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/15377

to review the following change.


Change subject: util: remove all gscoped_ptr
......................................................................

util: remove all gscoped_ptr

Except from callback_bind-test.cc, which tests gscoped_ptr functionality.

Change-Id: Ia110feea85b6ca43ba53d2d4783f47000794e196
---
M src/kudu/client/batcher.cc
M src/kudu/client/batcher.h
M src/kudu/client/scan_predicate-internal.h
M src/kudu/tablet/concurrent_btree.h
M src/kudu/tools/table_scanner.cc
M src/kudu/tools/table_scanner.h
M src/kudu/util/bloom_filter.h
M src/kudu/util/compression/compression-test.cc
M src/kudu/util/crc-test.cc
M src/kudu/util/debug/trace_event_impl.cc
M src/kudu/util/debug/trace_event_impl.h
M src/kudu/util/env_posix.cc
M src/kudu/util/hdr_histogram.cc
M src/kudu/util/hdr_histogram.h
M src/kudu/util/inline_slice-test.cc
M src/kudu/util/kernel_stack_watchdog.h
M src/kudu/util/memory/arena.h
M src/kudu/util/memory/memory.h
M src/kudu/util/metrics.h
M src/kudu/util/mutex.h
M src/kudu/util/nvm_cache.cc
M src/kudu/util/nvm_cache.h
M src/kudu/util/object_pool-test.cc
M src/kudu/util/object_pool.h
M src/kudu/util/path_util.cc
M src/kudu/util/path_util.h
M src/kudu/util/protoc-gen-insertions.cc
M src/kudu/util/trace.h
M src/kudu/util/user.cc
29 files changed, 162 insertions(+), 185 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/15377/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia110feea85b6ca43ba53d2d4783f47000794e196
Gerrit-Change-Number: 15377
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>

[kudu-CR] util: remove all gscoped ptr

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15377 )

Change subject: util: remove all gscoped_ptr
......................................................................


Patch Set 3: Verified+1

Overriding Jenkins, another dist-test temp dir issue.


-- 
To view, visit http://gerrit.cloudera.org:8080/15377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia110feea85b6ca43ba53d2d4783f47000794e196
Gerrit-Change-Number: 15377
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 06 Mar 2020 05:12:10 +0000
Gerrit-HasComments: No

[kudu-CR] util: remove all gscoped ptr

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15377 )

Change subject: util: remove all gscoped_ptr
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15377/1/src/kudu/util/env_posix.cc
File src/kudu/util/env_posix.cc:

http://gerrit.cloudera.org:8080/#/c/15377/1/src/kudu/util/env_posix.cc@1522
PS1, Line 1522: []
> Why this change?
Actually nevermind. Interesting that this worked before.



-- 
To view, visit http://gerrit.cloudera.org:8080/15377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia110feea85b6ca43ba53d2d4783f47000794e196
Gerrit-Change-Number: 15377
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 06 Mar 2020 02:24:03 +0000
Gerrit-HasComments: Yes

[kudu-CR] util: remove all gscoped ptr

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15377 )

Change subject: util: remove all gscoped_ptr
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia110feea85b6ca43ba53d2d4783f47000794e196
Gerrit-Change-Number: 15377
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 06 Mar 2020 04:57:42 +0000
Gerrit-HasComments: No

[kudu-CR] util: remove all gscoped ptr

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed a vote on this change.

Change subject: util: remove all gscoped_ptr
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/15377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ia110feea85b6ca43ba53d2d4783f47000794e196
Gerrit-Change-Number: 15377
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] util: remove all gscoped ptr

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15377 )

Change subject: util: remove all gscoped_ptr
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/15377/1/src/kudu/tablet/concurrent_btree.h
File src/kudu/tablet/concurrent_btree.h:

http://gerrit.cloudera.org:8080/#/c/15377/1/src/kudu/tablet/concurrent_btree.h@1101
PS1, Line 1101:  
> nit: maybe, drop the extra space while you are at it?
Done


http://gerrit.cloudera.org:8080/#/c/15377/1/src/kudu/util/env_posix.cc
File src/kudu/util/env_posix.cc:

http://gerrit.cloudera.org:8080/#/c/15377/1/src/kudu/util/env_posix.cc@1522
PS1, Line 1522: []
> Actually nevermind. Interesting that this worked before.
Yeah it was pretty weird.


http://gerrit.cloudera.org:8080/#/c/15377/1/src/kudu/util/user.cc
File src/kudu/util/user.cc:

http://gerrit.cloudera.org:8080/#/c/15377/1/src/kudu/util/user.cc@60
PS1, Line 60:   size_t bufsize = retval > 0 ? retval : 16384;
            : 
            :   unique_ptr<char[]> buf(new char[bufsize]);
> nit: is it possible to allocate 16K buffer on stack and then use it or it's
Well we still need to account for the possibility that sysconf() returns a value much greater than 16K. It's very unlikely, but I don't know if it's a guarantee.



-- 
To view, visit http://gerrit.cloudera.org:8080/15377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia110feea85b6ca43ba53d2d4783f47000794e196
Gerrit-Change-Number: 15377
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 06 Mar 2020 04:15:33 +0000
Gerrit-HasComments: Yes

[kudu-CR] util: remove all gscoped ptr

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15377 )

Change subject: util: remove all gscoped_ptr
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia110feea85b6ca43ba53d2d4783f47000794e196
Gerrit-Change-Number: 15377
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 06 Mar 2020 02:22:43 +0000
Gerrit-HasComments: No

[kudu-CR] util: remove all gscoped ptr

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15377 )

Change subject: util: remove all gscoped_ptr
......................................................................

util: remove all gscoped_ptr

Except from callback_bind-test.cc, which tests gscoped_ptr functionality.

Change-Id: Ia110feea85b6ca43ba53d2d4783f47000794e196
Reviewed-on: http://gerrit.cloudera.org:8080/15377
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/client/batcher.cc
M src/kudu/client/batcher.h
M src/kudu/client/scan_predicate-internal.h
M src/kudu/tablet/concurrent_btree.h
M src/kudu/tools/table_scanner.cc
M src/kudu/tools/table_scanner.h
M src/kudu/util/bloom_filter.h
M src/kudu/util/compression/compression-test.cc
M src/kudu/util/crc-test.cc
M src/kudu/util/debug/trace_event_impl.cc
M src/kudu/util/debug/trace_event_impl.h
M src/kudu/util/env_posix.cc
M src/kudu/util/hdr_histogram.cc
M src/kudu/util/hdr_histogram.h
M src/kudu/util/inline_slice-test.cc
M src/kudu/util/kernel_stack_watchdog.h
M src/kudu/util/memory/arena.h
M src/kudu/util/memory/memory.h
M src/kudu/util/metrics.h
M src/kudu/util/mutex.h
M src/kudu/util/nvm_cache.cc
M src/kudu/util/nvm_cache.h
M src/kudu/util/object_pool-test.cc
M src/kudu/util/object_pool.h
M src/kudu/util/path_util.cc
M src/kudu/util/path_util.h
M src/kudu/util/protoc-gen-insertions.cc
M src/kudu/util/trace.h
M src/kudu/util/user.cc
29 files changed, 167 insertions(+), 189 deletions(-)

Approvals:
  Andrew Wong: Looks good to me, approved
  Adar Dembo: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia110feea85b6ca43ba53d2d4783f47000794e196
Gerrit-Change-Number: 15377
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] util: remove all gscoped ptr

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15377

to look at the new patch set (#3).

Change subject: util: remove all gscoped_ptr
......................................................................

util: remove all gscoped_ptr

Except from callback_bind-test.cc, which tests gscoped_ptr functionality.

Change-Id: Ia110feea85b6ca43ba53d2d4783f47000794e196
---
M src/kudu/client/batcher.cc
M src/kudu/client/batcher.h
M src/kudu/client/scan_predicate-internal.h
M src/kudu/tablet/concurrent_btree.h
M src/kudu/tools/table_scanner.cc
M src/kudu/tools/table_scanner.h
M src/kudu/util/bloom_filter.h
M src/kudu/util/compression/compression-test.cc
M src/kudu/util/crc-test.cc
M src/kudu/util/debug/trace_event_impl.cc
M src/kudu/util/debug/trace_event_impl.h
M src/kudu/util/env_posix.cc
M src/kudu/util/hdr_histogram.cc
M src/kudu/util/hdr_histogram.h
M src/kudu/util/inline_slice-test.cc
M src/kudu/util/kernel_stack_watchdog.h
M src/kudu/util/memory/arena.h
M src/kudu/util/memory/memory.h
M src/kudu/util/metrics.h
M src/kudu/util/mutex.h
M src/kudu/util/nvm_cache.cc
M src/kudu/util/nvm_cache.h
M src/kudu/util/object_pool-test.cc
M src/kudu/util/object_pool.h
M src/kudu/util/path_util.cc
M src/kudu/util/path_util.h
M src/kudu/util/protoc-gen-insertions.cc
M src/kudu/util/trace.h
M src/kudu/util/user.cc
29 files changed, 167 insertions(+), 189 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/15377/3
-- 
To view, visit http://gerrit.cloudera.org:8080/15377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia110feea85b6ca43ba53d2d4783f47000794e196
Gerrit-Change-Number: 15377
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] util: remove all gscoped ptr

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15377 )

Change subject: util: remove all gscoped_ptr
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15377/1/src/kudu/util/env_posix.cc
File src/kudu/util/env_posix.cc:

http://gerrit.cloudera.org:8080/#/c/15377/1/src/kudu/util/env_posix.cc@1522
PS1, Line 1522: []
Why this change?



-- 
To view, visit http://gerrit.cloudera.org:8080/15377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia110feea85b6ca43ba53d2d4783f47000794e196
Gerrit-Change-Number: 15377
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 06 Mar 2020 02:22:31 +0000
Gerrit-HasComments: Yes

[kudu-CR] util: remove all gscoped ptr

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15377

to look at the new patch set (#2).

Change subject: util: remove all gscoped_ptr
......................................................................

util: remove all gscoped_ptr

Except from callback_bind-test.cc, which tests gscoped_ptr functionality.

Change-Id: Ia110feea85b6ca43ba53d2d4783f47000794e196
---
M src/kudu/client/batcher.cc
M src/kudu/client/batcher.h
M src/kudu/client/scan_predicate-internal.h
M src/kudu/tablet/concurrent_btree.h
M src/kudu/tools/table_scanner.cc
M src/kudu/tools/table_scanner.h
M src/kudu/util/bloom_filter.h
M src/kudu/util/compression/compression-test.cc
M src/kudu/util/crc-test.cc
M src/kudu/util/debug/trace_event_impl.cc
M src/kudu/util/debug/trace_event_impl.h
M src/kudu/util/env_posix.cc
M src/kudu/util/hdr_histogram.cc
M src/kudu/util/hdr_histogram.h
M src/kudu/util/inline_slice-test.cc
M src/kudu/util/kernel_stack_watchdog.h
M src/kudu/util/memory/arena.h
M src/kudu/util/memory/memory.h
M src/kudu/util/metrics.h
M src/kudu/util/mutex.h
M src/kudu/util/nvm_cache.cc
M src/kudu/util/nvm_cache.h
M src/kudu/util/object_pool-test.cc
M src/kudu/util/object_pool.h
M src/kudu/util/path_util.cc
M src/kudu/util/path_util.h
M src/kudu/util/protoc-gen-insertions.cc
M src/kudu/util/trace.h
M src/kudu/util/user.cc
29 files changed, 167 insertions(+), 188 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/15377/2
-- 
To view, visit http://gerrit.cloudera.org:8080/15377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia110feea85b6ca43ba53d2d4783f47000794e196
Gerrit-Change-Number: 15377
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] util: remove all gscoped ptr

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15377 )

Change subject: util: remove all gscoped_ptr
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/15377/1/src/kudu/tablet/concurrent_btree.h
File src/kudu/tablet/concurrent_btree.h:

http://gerrit.cloudera.org:8080/#/c/15377/1/src/kudu/tablet/concurrent_btree.h@1101
PS1, Line 1101:  
nit: maybe, drop the extra space while you are at it?


http://gerrit.cloudera.org:8080/#/c/15377/1/src/kudu/util/user.cc
File src/kudu/util/user.cc:

http://gerrit.cloudera.org:8080/#/c/15377/1/src/kudu/util/user.cc@60
PS1, Line 60:   size_t bufsize = retval > 0 ? retval : 16384;
            : 
            :   unique_ptr<char[]> buf(new char[bufsize]);
nit: is it possible to allocate 16K buffer on stack and then use it or it's part instead of calling new?  Adding CHECK_LE(retval, 16384) for sanity check.



-- 
To view, visit http://gerrit.cloudera.org:8080/15377
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia110feea85b6ca43ba53d2d4783f47000794e196
Gerrit-Change-Number: 15377
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 06 Mar 2020 03:52:02 +0000
Gerrit-HasComments: Yes