You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ashutosh Kelkar <as...@clogeny.com> on 2014/12/18 07:39:39 UTC
Review Request 29194: CLOUDSTACK-8087: Fixed
test_vpc_on_host_maintenance.py
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29194/
-----------------------------------------------------------
Review request for cloudstack and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-8087
https://issues.apache.org/jira/browse/CLOUDSTACK-8087
Repository: cloudstack-git
Description
-------
Passed start=False while creating VPC because it is being created when hosts are in maintenance state.
Fixed pep8 issues too.
Diffs
-----
test/integration/component/maint/test_vpc_on_host_maintenance.py eb3360a
Diff: https://reviews.apache.org/r/29194/diff/
Testing
-------
Yes.
It still fails while asserting the state of VPC. On hold until heard from developer. Logged product bug for this.
Thanks,
Ashutosh Kelkar
Re: Review Request 29194: CLOUDSTACK-8087: Fixed
test_vpc_on_host_maintenance.py
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29194/#review65601
-----------------------------------------------------------
Ship it!
162f61b73fa0e8faa981bc090df27fea8afc4c50 master
6c722c9d219ae3bedad12a28105800b096eeb147 4.5
- SrikanteswaraRao Talluri
On Dec. 18, 2014, 6:39 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29194/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2014, 6:39 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-8087
> https://issues.apache.org/jira/browse/CLOUDSTACK-8087
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Passed start=False while creating VPC because it is being created when hosts are in maintenance state.
> Fixed pep8 issues too.
>
>
> Diffs
> -----
>
> test/integration/component/maint/test_vpc_on_host_maintenance.py eb3360a
>
> Diff: https://reviews.apache.org/r/29194/diff/
>
>
> Testing
> -------
>
> Yes.
>
> It still fails while asserting the state of VPC. On hold until heard from developer. Logged product bug for this.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>