[jira] [Commented] (PHOENIX-1587) Error deserializing empty array (which represents null)

["James Taylor (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-1587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14279162#comment-14279162 ] 

James Taylor commented on PHOENIX-1587:
---------------------------------------

+1 on the patch. I'll commit this to 4.0 so it makes the 4.3 release. Thanks for the contribution, [~janvanbesien].

> Error deserializing empty array (which represents null)
> -------------------------------------------------------
>
>                 Key: PHOENIX-1587
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1587
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Jan Van Besien
>            Assignee: Jan Van Besien
>         Attachments: PHOENIX-1587.patch
>
>
> Serializing null arrays results in an empty byte[]. The deserialization logic in PArrayDataType#createPhoenixArray has a check to return null if the provided byte[] is empty, however it checks the length of the byte[] rather than the provided length parameter. Note that the provided byte[] is typically the whole underlying row; it has to be interpreted only from offset to length.
> Therefor, the check has to be replaced with a check on length rather than on bytes.length.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)