You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/10/20 10:37:06 UTC
[GitHub] [ignite] isapego opened a new pull request #8375: IGNITE-13598: Fix Node.js jasmine tests
isapego opened a new pull request #8375:
URL: https://github.com/apache/ignite/pull/8375
Set specific Jasmine version, which does not use ES6 syntax.
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn commented on a change in pull request #8375: IGNITE-13598: Fix Node.js tests. Set jasmine version to 3.6.1
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on a change in pull request #8375:
URL: https://github.com/apache/ignite/pull/8375#discussion_r508451270
##########
File path: modules/platforms/nodejs/package.json
##########
@@ -32,8 +32,9 @@
"test:auth_example": "node ./spec/ExamplesExecutor.js AuthExample"
},
"devDependencies": {
- "jasmine": "latest",
+ "jasmine": "3.6.1",
Review comment:
Should we used a fixed version for other dependencies below?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] asfgit closed pull request #8375: IGNITE-13598: Fix Node.js tests. Set jasmine version to 3.6.1
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #8375:
URL: https://github.com/apache/ignite/pull/8375
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] isapego commented on a change in pull request #8375: IGNITE-13598: Fix Node.js tests. Set jasmine version to 3.6.1
Posted by GitBox <gi...@apache.org>.
isapego commented on a change in pull request #8375:
URL: https://github.com/apache/ignite/pull/8375#discussion_r508470706
##########
File path: modules/platforms/nodejs/package.json
##########
@@ -32,8 +32,9 @@
"test:auth_example": "node ./spec/ExamplesExecutor.js AuthExample"
},
"devDependencies": {
- "jasmine": "latest",
+ "jasmine": "3.6.1",
Review comment:
I fixed other dev dependencies and decided to leave project dependencies as is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org