You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/04/02 18:21:08 UTC

[GitHub] [commons-geometry] darkma773r commented on a change in pull request #143: GEOMETRY-119: adding Vector.normalizeOrNull() method

darkma773r commented on a change in pull request #143:
URL: https://github.com/apache/commons-geometry/pull/143#discussion_r606358988



##########
File path: commons-geometry-core/src/main/java/org/apache/commons/geometry/core/Vector.java
##########
@@ -93,11 +93,22 @@
 
     /** Get a normalized vector aligned with the instance. The returned
      * vector has a magnitude of 1.
-     * @return a new normalized vector
-     * @throws IllegalArgumentException if the norm is zero, NaN, or infinite
+     * @return normalized vector
+     * @throws IllegalArgumentException if the norm (or norm inverse, if applicable)
+     *      is zero, NaN, or infinite

Review comment:
       I find it easier to read when the second line of tag content is indented. It doesn't affect the generated docs so it's a personal preference thing. Is that what you're referring to?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org