You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/05/16 02:15:12 UTC

[GitHub] [fineract] nemux edited a comment on pull request #885: Email sending fixed and improvements (See Fineract-699)

nemux edited a comment on pull request #885:
URL: https://github.com/apache/fineract/pull/885#issuecomment-629555617


   > @nemux anything we can do to help you wrap this up?
   > 
   > PS: If you think adding a test for this is too much to ask for this PR, I also don't really mind at all if we merge this without a test (once you made it pass the build, of course; and provided feedback the other more minor points raised above), and then create another JIRA and you perhaps contribute the test in a later PR. If Email sending is currently broken (it is?), then I guess fixing it even without a test yet is still better than having it broken! 😄
   
   Hello @vorburger ! i'm going to work on this, just let me have a little time to continue with that! In order to add the testt and fix compilation issues!
   
   And I think that if the test is necessary, let's add it to continue improvement the quality of the Fineract project!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org