You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Jukka Zitting (JIRA)" <ji...@apache.org> on 2007/07/02 17:27:04 UTC
[jira] Created: (JCR-996) Name and Path interfaces in SPI
Name and Path interfaces in SPI
-------------------------------
Key: JCR-996
URL: https://issues.apache.org/jira/browse/JCR-996
Project: Jackrabbit
Issue Type: Improvement
Components: SPI
Reporter: Jukka Zitting
The SPI interface currently has a dependency to QName and Path classes in jackrabbit-jcr-commons. Architecturally it would be better to have Name and Path interfaces in the SPI package, and have the implementing classes in commons.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (JCR-996) Name and Path interfaces in
SPI
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521347 ]
anchela edited comment on JCR-996 at 10/9/07 11:19 PM:
------------------------------------------------------
Follow up discussion 'Distribution of commons classes':
http://www.mail-archive.com/dev@jackrabbit.apache.org/msg06698.html
and
see JCR-1169 for patches including the proposed changes for both jackrabbit-jcr-commons and jackrabbit-spi-commons.
was (Author: anchela):
Follow up discussion 'Distribution of commons classes':
http://www.mail-archive.com/dev@jackrabbit.apache.org/msg06698.html
and
JCR-1169
> Name and Path interfaces in SPI
> -------------------------------
>
> Key: JCR-996
> URL: https://issues.apache.org/jira/browse/JCR-996
> Project: Jackrabbit
> Issue Type: Improvement
> Components: SPI
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Attachments: JCR_996_spi.patch, JCR_996_spi_2.patch
>
>
> The SPI interface currently has a dependency to QName and Path classes in jackrabbit-jcr-commons. Architecturally it would be better to have Name and Path interfaces in the SPI package, and have the implementing classes in commons.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-996) Name and Path interfaces in SPI
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated JCR-996:
------------------------------
Fix Version/s: 1.4
> Name and Path interfaces in SPI
> -------------------------------
>
> Key: JCR-996
> URL: https://issues.apache.org/jira/browse/JCR-996
> Project: Jackrabbit
> Issue Type: Improvement
> Components: SPI
> Reporter: Jukka Zitting
> Assignee: angela
> Fix For: 1.4
>
> Attachments: JCR_996_spi.patch, JCR_996_spi_2.patch, JCR_996_spi_3.patch
>
>
> The SPI interface currently has a dependency to QName and Path classes in jackrabbit-jcr-commons. Architecturally it would be better to have Name and Path interfaces in the SPI package, and have the implementing classes in commons.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-996) Name and Path interfaces in SPI
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515617 ]
angela commented on JCR-996:
----------------------------
apart from discussing the interfaces, we may take a look at the implications of Path/Name interfaces.
I could see the followings issues that we need to get a consensus about:
- Would it be an option to change the derived interfaces in jackrabbit-jcr-commons in order to use the Name/Path
interfaces instead of QName/Path classes. I think of
- NamespaceResolver
- NameCache
- PathCache
- The same question arises for
- NameFormat
- PathFormat
Since both the 'core' and the various modules in the spi contrib make use of the mentioned functionality present in jackrabbit-jcr-commons, i think this issue should be discussed on a broader basis.
Copying the utilities to the SPI-commons just in order to be able the change them doesn't seem a sensible solution to me.
> Name and Path interfaces in SPI
> -------------------------------
>
> Key: JCR-996
> URL: https://issues.apache.org/jira/browse/JCR-996
> Project: Jackrabbit
> Issue Type: Improvement
> Components: SPI
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Attachments: JCR_996_spi.patch
>
>
> The SPI interface currently has a dependency to QName and Path classes in jackrabbit-jcr-commons. Architecturally it would be better to have Name and Path interfaces in the SPI package, and have the implementing classes in commons.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-996) Name and Path interfaces in SPI
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
angela updated JCR-996:
-----------------------
Attachment: JCR_996_spi_3.patch
Included tobis suggestions:
- additional method Path.getString
- additional method Path.Element.getString
and define PathFactory.create(String) to require a String in the format of
Path.getString (thus leaving 'toString' to the implementation)
> Name and Path interfaces in SPI
> -------------------------------
>
> Key: JCR-996
> URL: https://issues.apache.org/jira/browse/JCR-996
> Project: Jackrabbit
> Issue Type: Improvement
> Components: SPI
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Attachments: JCR_996_spi.patch, JCR_996_spi_2.patch, JCR_996_spi_3.patch
>
>
> The SPI interface currently has a dependency to QName and Path classes in jackrabbit-jcr-commons. Architecturally it would be better to have Name and Path interfaces in the SPI package, and have the implementing classes in commons.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-996) Name and Path interfaces in SPI
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
angela updated JCR-996:
-----------------------
Attachment: JCR_996_spi.patch
in order to have a basis for discussions I started with a patch for the SPI interfaces defining:
- Path interface
- Name interface
- NameFactory interface
- PathFactory interface
and consequently removing the existing dependency to jackrabbit-jcr-commons in the pom.xml and in all other SPI interfacing making usage of that dependency.
> Name and Path interfaces in SPI
> -------------------------------
>
> Key: JCR-996
> URL: https://issues.apache.org/jira/browse/JCR-996
> Project: Jackrabbit
> Issue Type: Improvement
> Components: SPI
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Attachments: JCR_996_spi.patch
>
>
> The SPI interface currently has a dependency to QName and Path classes in jackrabbit-jcr-commons. Architecturally it would be better to have Name and Path interfaces in the SPI package, and have the implementing classes in commons.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-996) Name and Path interfaces in SPI
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12535282 ]
Jukka Zitting commented on JCR-996:
-----------------------------------
+1, the patch looks good to me
PS. I'd like to go further to a design where the SPI client wouldn't necessarily need to parse the names and paths before passing them down to the SPI implementation, but this is already a good step forward and it's probably best not to overlay such design changes on top of the proposed restructuring.
> Name and Path interfaces in SPI
> -------------------------------
>
> Key: JCR-996
> URL: https://issues.apache.org/jira/browse/JCR-996
> Project: Jackrabbit
> Issue Type: Improvement
> Components: SPI
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Attachments: JCR_996_spi.patch, JCR_996_spi_2.patch, JCR_996_spi_3.patch
>
>
> The SPI interface currently has a dependency to QName and Path classes in jackrabbit-jcr-commons. Architecturally it would be better to have Name and Path interfaces in the SPI package, and have the implementing classes in commons.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-996) Name and Path interfaces in SPI
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12535279 ]
angela commented on JCR-996:
----------------------------
if nobody objects within the next couple of days, i assume that we are having lazy consensus on this issue
and will commit the changes.
> Name and Path interfaces in SPI
> -------------------------------
>
> Key: JCR-996
> URL: https://issues.apache.org/jira/browse/JCR-996
> Project: Jackrabbit
> Issue Type: Improvement
> Components: SPI
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Attachments: JCR_996_spi.patch, JCR_996_spi_2.patch, JCR_996_spi_3.patch
>
>
> The SPI interface currently has a dependency to QName and Path classes in jackrabbit-jcr-commons. Architecturally it would be better to have Name and Path interfaces in the SPI package, and have the implementing classes in commons.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-996) Name and Path interfaces in SPI
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515632 ]
Jukka Zitting commented on JCR-996:
-----------------------------------
Thanks for taking this up! I have some ideas on the commons packages, I'll follow up on dev@.
> Name and Path interfaces in SPI
> -------------------------------
>
> Key: JCR-996
> URL: https://issues.apache.org/jira/browse/JCR-996
> Project: Jackrabbit
> Issue Type: Improvement
> Components: SPI
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Attachments: JCR_996_spi.patch
>
>
> The SPI interface currently has a dependency to QName and Path classes in jackrabbit-jcr-commons. Architecturally it would be better to have Name and Path interfaces in the SPI package, and have the implementing classes in commons.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (JCR-996) Name and Path interfaces in
SPI
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521347 ]
anchela edited comment on JCR-996 at 10/9/07 8:02 AM:
-----------------------------------------------------
Follow up discussion 'Distribution of commons classes':
http://www.mail-archive.com/dev@jackrabbit.apache.org/msg06698.html
and
JCR-1169
was (Author: anchela):
Follow up discussion 'Distribution of commons classes':
http://www.mail-archive.com/dev@jackrabbit.apache.org/msg06698.html
> Name and Path interfaces in SPI
> -------------------------------
>
> Key: JCR-996
> URL: https://issues.apache.org/jira/browse/JCR-996
> Project: Jackrabbit
> Issue Type: Improvement
> Components: SPI
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Attachments: JCR_996_spi.patch, JCR_996_spi_2.patch
>
>
> The SPI interface currently has a dependency to QName and Path classes in jackrabbit-jcr-commons. Architecturally it would be better to have Name and Path interfaces in the SPI package, and have the implementing classes in commons.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-996) Name and Path interfaces in SPI
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521347 ]
angela commented on JCR-996:
----------------------------
Follow up discussion 'Distribution of commons classes':
http://www.mail-archive.com/dev@jackrabbit.apache.org/msg06698.html
> Name and Path interfaces in SPI
> -------------------------------
>
> Key: JCR-996
> URL: https://issues.apache.org/jira/browse/JCR-996
> Project: Jackrabbit
> Issue Type: Improvement
> Components: SPI
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Attachments: JCR_996_spi.patch
>
>
> The SPI interface currently has a dependency to QName and Path classes in jackrabbit-jcr-commons. Architecturally it would be better to have Name and Path interfaces in the SPI package, and have the implementing classes in commons.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (JCR-996) Name and Path interfaces in SPI
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting reassigned JCR-996:
---------------------------------
Assignee: Jukka Zitting
> Name and Path interfaces in SPI
> -------------------------------
>
> Key: JCR-996
> URL: https://issues.apache.org/jira/browse/JCR-996
> Project: Jackrabbit
> Issue Type: Improvement
> Components: SPI
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
>
> The SPI interface currently has a dependency to QName and Path classes in jackrabbit-jcr-commons. Architecturally it would be better to have Name and Path interfaces in the SPI package, and have the implementing classes in commons.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JCR-996) Name and Path interfaces in SPI
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
angela resolved JCR-996.
------------------------
Resolution: Fixed
Assignee: angela (was: Jukka Zitting)
commited changes to jackrabbit-spi and adjusted
- jackrabbit-spi-commons
- contrib\spi
> Name and Path interfaces in SPI
> -------------------------------
>
> Key: JCR-996
> URL: https://issues.apache.org/jira/browse/JCR-996
> Project: Jackrabbit
> Issue Type: Improvement
> Components: SPI
> Reporter: Jukka Zitting
> Assignee: angela
> Attachments: JCR_996_spi.patch, JCR_996_spi_2.patch, JCR_996_spi_3.patch
>
>
> The SPI interface currently has a dependency to QName and Path classes in jackrabbit-jcr-commons. Architecturally it would be better to have Name and Path interfaces in the SPI package, and have the implementing classes in commons.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-996) Name and Path interfaces in SPI
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
angela updated JCR-996:
-----------------------
Attachment: JCR_996_spi_2.patch
improved patch.
> Name and Path interfaces in SPI
> -------------------------------
>
> Key: JCR-996
> URL: https://issues.apache.org/jira/browse/JCR-996
> Project: Jackrabbit
> Issue Type: Improvement
> Components: SPI
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
> Attachments: JCR_996_spi.patch, JCR_996_spi_2.patch
>
>
> The SPI interface currently has a dependency to QName and Path classes in jackrabbit-jcr-commons. Architecturally it would be better to have Name and Path interfaces in the SPI package, and have the implementing classes in commons.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.