You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Kristine Hahn (Code Review)" <ge...@cloudera.org> on 2020/04/09 00:59:04 UTC
[Impala-ASF-CR] IMPALA-9616
Kristine Hahn has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15692
Change subject: IMPALA-9616
......................................................................
IMPALA-9616
Added new query options topics:
--A topic to cover the spill-to-disk compression support
--A topic for that describes the disk_spill_punch_holes option
Change-Id: I3694fe97d74697777a8d50288b406b8eca0aa9fb
---
M docs/impala.ditamap
A docs/topics/impala_spill_compression_codec.xml
A docs/topics/impala_spill_punch_holes.xml
3 files changed, 146 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/15692/1
--
To view, visit http://gerrit.cloudera.org:8080/15692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3694fe97d74697777a8d50288b406b8eca0aa9fb
Gerrit-Change-Number: 15692
Gerrit-PatchSet: 1
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
[Impala-ASF-CR] IMPALA-9616
Posted by "Kristine Hahn (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15692
to look at the new patch set (#2).
Change subject: IMPALA-9616
......................................................................
IMPALA-9616
Documented startup option descriptions per review comments:
--To cover the spill-to-disk compression support
--To use the disk_spill_punch_holes as required
Included examples that need to be reviewed.
Change-Id: I3694fe97d74697777a8d50288b406b8eca0aa9fb
---
M docs/impala.ditamap
M docs/topics/impala_disk_space.xml
2 files changed, 35 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/15692/2
--
To view, visit http://gerrit.cloudera.org:8080/15692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3694fe97d74697777a8d50288b406b8eca0aa9fb
Gerrit-Change-Number: 15692
Gerrit-PatchSet: 2
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9616
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15692 )
Change subject: IMPALA-9616
......................................................................
Patch Set 3:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/578/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/15692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3694fe97d74697777a8d50288b406b8eca0aa9fb
Gerrit-Change-Number: 15692
Gerrit-PatchSet: 3
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Apr 2020 16:08:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9616 [DOC]: Document spill to disk startup options
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15692 )
Change subject: IMPALA-9616 [DOC]: Document spill to disk startup options
......................................................................
Patch Set 4: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/582/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/15692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3694fe97d74697777a8d50288b406b8eca0aa9fb
Gerrit-Change-Number: 15692
Gerrit-PatchSet: 4
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Apr 2020 01:07:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9616
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15692 )
Change subject: IMPALA-9616
......................................................................
Patch Set 3: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/578/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/15692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3694fe97d74697777a8d50288b406b8eca0aa9fb
Gerrit-Change-Number: 15692
Gerrit-PatchSet: 3
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Apr 2020 16:16:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9616
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15692 )
Change subject: IMPALA-9616
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/575/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/15692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3694fe97d74697777a8d50288b406b8eca0aa9fb
Gerrit-Change-Number: 15692
Gerrit-PatchSet: 1
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Apr 2020 00:59:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9616
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15692 )
Change subject: IMPALA-9616
......................................................................
Patch Set 3:
SOrry for the delay, I need to take another look at this
--
To view, visit http://gerrit.cloudera.org:8080/15692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3694fe97d74697777a8d50288b406b8eca0aa9fb
Gerrit-Change-Number: 15692
Gerrit-PatchSet: 3
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Apr 2020 00:37:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9616
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15692 )
Change subject: IMPALA-9616
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/577/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/15692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3694fe97d74697777a8d50288b406b8eca0aa9fb
Gerrit-Change-Number: 15692
Gerrit-PatchSet: 2
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Apr 2020 15:50:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9616 [DOC]: Document spill to disk startup options
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15692 )
Change subject: IMPALA-9616 [DOC]: Document spill to disk startup options
......................................................................
IMPALA-9616 [DOC]: Document spill to disk startup options
Documented startup option descriptions per review comments:
--To cover the spill-to-disk compression support
--To use the disk_spill_punch_holes as required
Included examples that need to be reviewed and minor edits.
Change-Id: I3694fe97d74697777a8d50288b406b8eca0aa9fb
Reviewed-on: http://gerrit.cloudera.org:8080/15692
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
---
M docs/impala.ditamap
M docs/topics/impala_disk_space.xml
2 files changed, 31 insertions(+), 3 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Tim Armstrong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3694fe97d74697777a8d50288b406b8eca0aa9fb
Gerrit-Change-Number: 15692
Gerrit-PatchSet: 5
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9616
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15692 )
Change subject: IMPALA-9616
......................................................................
Patch Set 1:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/15692/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15692/1//COMMIT_MSG@7
PS1, Line 7: IMPALA-9616
nit: can you briefly describe the change in the first line. This plays nicer with tools that only show the commit title. E.g.
git log --pretty=oneline
http://gerrit.cloudera.org:8080/#/c/15692/1/docs/topics/impala_spill_compression_codec.xml
File docs/topics/impala_spill_compression_codec.xml:
PS1:
These are startup parameters for Impala instead of query options, so don't fit in this part of the docs. The startup parameters are not all documented in as consistent a way, they are mostly mentioned in the various administration topics.
I think these fit in impala_disk_space.xml, which discusses how to set -scratch_dirs (a related option). https://jenkins.impala.io/job/docs-build-ub1604/1604/artifact/Impala/docs/build/html/topics/impala_disk_space.html
http://gerrit.cloudera.org:8080/#/c/15692/1/docs/topics/impala_spill_compression_codec.xml@52
PS1, Line 52: allowed
These are more the recommended values instead of the only allowed values (I read this as excluding other values).
This supports the full range of values supported by the COMPRESSION_CODEC query option. I don't think admins should generally be setting it to other values, but it's probably good to at least document the possibilities.
http://gerrit.cloudera.org:8080/#/c/15692/1/docs/topics/impala_spill_compression_codec.xml@64
PS1, Line 64: <b>Default:</b> <codeph>ZSTD</codeph>
The default is NONE
http://gerrit.cloudera.org:8080/#/c/15692/1/docs/topics/impala_spill_compression_codec.xml@67
PS1, Line 67: You can use this query option with the DISK_SPILL_PUNCH_HOLES query option.
This is a must, i.e. If you set --disk_spill_compression_codec to a value other than NONE, you must set --disk_spill_punch_holes to true.
http://gerrit.cloudera.org:8080/#/c/15692/1/docs/topics/impala_spill_punch_holes.xml
File docs/topics/impala_spill_punch_holes.xml:
http://gerrit.cloudera.org:8080/#/c/15692/1/docs/topics/impala_spill_punch_holes.xml@41
PS1, Line 41: To limit the amount of data spilled during pre-aggregation, you
: enable hole punching support.
This is not right, it's not related to the preaggregation change, maybe just remove?
http://gerrit.cloudera.org:8080/#/c/15692/1/docs/topics/impala_spill_punch_holes.xml@49
PS1, Line 49: <p>True allocates a range of the actual compressed size and punch holes
Not sure the best way to explain what it does, since it's relatively low level. My attempt is something like: "When this option is enabled, the hole punching feature supported by many filesystems is used to reclaim space in scratch files during execution of a query that spills to disk. This results in lower scratch space requirements in many cases, especially when combined with disk spill compression. When this option is not enabled, scratch space is still recycled by a query, but less effectively in many cases."
http://gerrit.cloudera.org:8080/#/c/15692/1/docs/topics/impala_spill_punch_holes.xml@52
PS1, Line 52: <b>Type:</b> <codeph>BOOLEAN</codeph>
We should mention that the filesystems for the directories specified in -scratch_dirs must support hole punching if this option is enabled. It's the same for the data cache (see impala_data_cache.xml - that always requires hole punching support).
--
To view, visit http://gerrit.cloudera.org:8080/15692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3694fe97d74697777a8d50288b406b8eca0aa9fb
Gerrit-Change-Number: 15692
Gerrit-PatchSet: 1
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Apr 2020 04:12:02 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9616
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15692 )
Change subject: IMPALA-9616
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/577/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/15692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3694fe97d74697777a8d50288b406b8eca0aa9fb
Gerrit-Change-Number: 15692
Gerrit-PatchSet: 2
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Apr 2020 15:59:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9616
Posted by "Kristine Hahn (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15692
to look at the new patch set (#3).
Change subject: IMPALA-9616
......................................................................
IMPALA-9616
Documented startup option descriptions per review comments:
--To cover the spill-to-disk compression support
--To use the disk_spill_punch_holes as required
Included examples that need to be reviewed and minor edits.
Change-Id: I3694fe97d74697777a8d50288b406b8eca0aa9fb
---
M docs/impala.ditamap
M docs/topics/impala_disk_space.xml
2 files changed, 31 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/15692/3
--
To view, visit http://gerrit.cloudera.org:8080/15692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3694fe97d74697777a8d50288b406b8eca0aa9fb
Gerrit-Change-Number: 15692
Gerrit-PatchSet: 3
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9616
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15692 )
Change subject: IMPALA-9616
......................................................................
Patch Set 3:
(1 comment)
Looks good to me aside from the commit message.
http://gerrit.cloudera.org:8080/#/c/15692/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15692/1//COMMIT_MSG@7
PS1, Line 7: IMPALA-9616
> nit: can you briefly describe the change in the first line. This plays nice
Looks like this comment got missed.
--
To view, visit http://gerrit.cloudera.org:8080/15692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3694fe97d74697777a8d50288b406b8eca0aa9fb
Gerrit-Change-Number: 15692
Gerrit-PatchSet: 3
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Apr 2020 00:42:56 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9616 [DOC]: Document spill to disk startup options
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15692 )
Change subject: IMPALA-9616 [DOC]: Document spill to disk startup options
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3694fe97d74697777a8d50288b406b8eca0aa9fb
Gerrit-Change-Number: 15692
Gerrit-PatchSet: 4
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Apr 2020 00:53:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9616 [DOC]: Document spill to disk startup options
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15692 )
Change subject: IMPALA-9616 [DOC]: Document spill to disk startup options
......................................................................
Patch Set 4:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/582/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/15692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3694fe97d74697777a8d50288b406b8eca0aa9fb
Gerrit-Change-Number: 15692
Gerrit-PatchSet: 4
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Apr 2020 00:58:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9616
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15692 )
Change subject: IMPALA-9616
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/575/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/15692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3694fe97d74697777a8d50288b406b8eca0aa9fb
Gerrit-Change-Number: 15692
Gerrit-PatchSet: 1
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Apr 2020 01:07:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9616 [DOC]: Document spill to disk startup options
Posted by "Kristine Hahn (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15692
to look at the new patch set (#4).
Change subject: IMPALA-9616 [DOC]: Document spill to disk startup options
......................................................................
IMPALA-9616 [DOC]: Document spill to disk startup options
Documented startup option descriptions per review comments:
--To cover the spill-to-disk compression support
--To use the disk_spill_punch_holes as required
Included examples that need to be reviewed and minor edits.
Change-Id: I3694fe97d74697777a8d50288b406b8eca0aa9fb
---
M docs/impala.ditamap
M docs/topics/impala_disk_space.xml
2 files changed, 31 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/15692/4
--
To view, visit http://gerrit.cloudera.org:8080/15692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3694fe97d74697777a8d50288b406b8eca0aa9fb
Gerrit-Change-Number: 15692
Gerrit-PatchSet: 4
Gerrit-Owner: Kristine Hahn <kh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>