[GitHub] [arrow-adbc] kou commented on a diff in pull request #662: ci: 0.4.0 release fixes

["kou (via GitHub)" <gi...@apache.org>]

kou commented on code in PR #662:
URL: https://github.com/apache/arrow-adbc/pull/662#discussion_r1187577205


##########
ruby/Gemfile:
##########
@@ -23,5 +23,19 @@ gemspec
 
 gem "bundler"
 gem "rake"
-gem "red-arrow"
+# Use the version of red-arrow based on the available arrow-glib version
+red_arrow_version = ">= 0"
+IO.pipe do |input, output|
+  begin
+    pid = spawn("pkg-config", "--modversion", "arrow-glib",
+                out: output,
+                err: File::NULL)
+    output.close
+    Process.waitpid(pid)
+    arrow_glib_version = input.read.strip.sub(/-SNAPSHOT\z/, "")
+    red_arrow_version = "<= #{arrow_glib_version}"
+  rescue SystemCallError
+  end
+end
+gem "red-arrow", red_arrow_version

Review Comment:
   We can remove `red-arrow` entirely from this `Gemfile` because we specify version in `red-arrow.gemspec`.



##########
ci/scripts/glib_test.sh:
##########
@@ -61,6 +61,14 @@ test_subproject() {
                --with-cppflags=-D_LIBCPP_DISABLE_AVAILABILITY
     fi
 
+    # Install consistent version of red-arrow for given arrow-glib
+    local -r arrow_glib_version=$(pkg-config --modversion arrow-glib | sed -e 's/-SNAPSHOT$//g' || :)
+    local red_arrow=""

Review Comment:
   Sorry for not working `gem install red-arrow:X.Y.Z pkg/*.gem`...
   
   We can remove the `red_arrow` variable entirely.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org