[GitHub] [submarine] pingsutw commented on a change in pull request #366: SUBMARINE-579. [WEB] Add duration information to experiment

[GitBox <gi...@apache.org>]

pingsutw commented on a change in pull request #366:
URL: https://github.com/apache/submarine/pull/366#discussion_r463903617



##########
File path: submarine-workbench/workbench-web-ng/src/app/pages/workbench/experiment/experiment-info/experiment-info.component.ts
##########
@@ -116,6 +127,31 @@ export class ExperimentInfoComponent implements OnInit {
     );
   }
 
+  durationHandle(secs: number) {
+    var hr = Math.floor(secs / 3600);
+    var min = Math.floor((secs - hr * 3600) / 60);
+    var sec = Math.round(secs) - hr * 3600 - min * 60;
+    var showHr;
+    var showMin;
+    var showSec;

Review comment:
       ```suggestion
       const hr = Math.floor(secs / 3600);
       const min = Math.floor((secs - hr * 3600) / 60);
       const sec = Math.round(secs) - hr * 3600 - min * 60;
       let showHr;
       let showMin;
       let showSec;
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org