[jira] [Commented] (MAPREDUCE-3723) TestAMWebServicesJobs & TestHSWebServicesJobs incorrectly asserting tests

["Hadoop QA (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193000#comment-13193000 ] 

Hadoop QA commented on MAPREDUCE-3723:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12511828/MAPREDUCE-3723.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests:
                  org.apache.hadoop.mapred.TestJobClientGetJob
                  org.apache.hadoop.mapred.TestMRWithDistributedCache
                  org.apache.hadoop.mapred.TestLocalModeWithNewApis

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1669//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1669//console

This message is automatically generated.
                
> TestAMWebServicesJobs & TestHSWebServicesJobs incorrectly asserting tests
> -------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3723
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3723
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, test, webapps
>    Affects Versions: 0.23.1, 0.24.0
>            Reporter: Bhallamudi Venkata Siva Kamesh
>         Attachments: MAPREDUCE-3723.patch
>
>
> While testing a patch for one of the MR issues, I found TestAMWebServicesJobs & TestHSWebServicesJobs incorrectly asserting tests. 
> Moreover tests may fail if
> {noformat}
> 	index of counterGroups > #counters in a particular counterGroup
> {noformat}
> {code:title=TestAMWebServicesJobs.java|borderStyle=solid}
> for (int j = 0; j < counters.length(); j++) {
>  JSONObject counter = counters.getJSONObject(i);
> {code}
> where is *i* is index of outer loop. It should be *j* instead of *i*.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira