[jira] [Created] (MATH-1652) comments about the formula of binomialCoefficient wrong

["nimo mayr (Jira)" <ji...@apache.org>]

nimo mayr created MATH-1652:
-------------------------------

             Summary: comments about the formula of binomialCoefficient wrong
                 Key: MATH-1652
                 URL: https://issues.apache.org/jira/browse/MATH-1652
             Project: Commons Math
          Issue Type: Improvement
            Reporter: nimo mayr


The class 
{color:#d8d8d8} org.apache.commons.math3.util.{color:#d25252}CombinatoricsUtils{color}{color}

within the method 
{color:#d8d8d8} {color}{color:#8dcbe2}public{color}{color:#d8d8d8} {color}{color:#8dcbe2}static{color}{color:#d8d8d8} {color}{color:#8dcbe2}long{color}{color:#d8d8d8} {color}{color:#bed6ff}binomialCoefficient{color}{color:#d8d8d8}({color}{color:#8dcbe2}final{color}{color:#d8d8d8} {color}{color:#8dcbe2}int{color}{color:#d8d8d8} {color}{color:#79abff}n{color}{color:#d8d8d8}, {color}{color:#8dcbe2}final{color}{color:#d8d8d8} {color}{color:#8dcbe2}int{color}{color:#d8d8d8} {color}{color:#79abff}k{color}{color:#d8d8d8}){color}

contains the following comments:
{color:#c7dd0c}// We use the formula{color}

{color:#d8d8d8} {color}{color:#c7dd0c}// (n choose k) = n! / (n-k)! / k!{color}

{color:#d8d8d8} {color}{color:#c7dd0c}// (n choose k) == ((n-k+1)*...*n) / (1*...*k){color}

{color:#d8d8d8} {color}{color:#c7dd0c}// which could be written{color}

{color:#d8d8d8} {color}{color:#c7dd0c}// (n choose k) == (n-1 choose k-1) * n / k{color}

 

I think, at the second line "{color:#c7dd0c}(n choose k) = n! / (n-k)! / k!{color:#172b4d}" must be written to "{color:#c7dd0c}(n choose k) = n! / (n-k)! * k!{color:#172b4d}".{color}{color}{color}{color}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)