You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/11/09 21:17:00 UTC
[jira] [Commented] (BEAM-2961) WindowingStrategy proto translation
does not translate OnTimeBehavior
[ https://issues.apache.org/jira/browse/BEAM-2961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246559#comment-16246559 ]
ASF GitHub Bot commented on BEAM-2961:
--------------------------------------
GitHub user tvalentyn opened a pull request:
https://github.com/apache/beam/pull/4108
Set OnTimeBehavior in windowing strategy to FIRE_ALWAYS.
This fixes python side of https://issues.apache.org/jira/browse/BEAM-2961.
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tvalentyn/beam patch-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/4108.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4108
----
commit 19b5fd09271bf90c5ad8ed91a2bd76f68b91f2e2
Author: tvalentyn <tv...@users.noreply.github.com>
Date: 2017-11-09T21:16:24Z
Set OnTimeBehavior in windowing strategy to FIRE_ALWAYS.
This fixes python side of https://issues.apache.org/jira/browse/BEAM-2961.
----
> WindowingStrategy proto translation does not translate OnTimeBehavior
> ---------------------------------------------------------------------
>
> Key: BEAM-2961
> URL: https://issues.apache.org/jira/browse/BEAM-2961
> Project: Beam
> Issue Type: Bug
> Components: runner-core
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: Blocker
> Fix For: 2.2.0
>
>
> During fixing https://issues.apache.org/jira/browse/BEAM-2959, it was discovered that we never translated this field appropriately.
> Not fixing this would lead to data loss/data corruption.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)