You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by GitBox <gi...@apache.org> on 2022/08/30 09:09:12 UTC

[GitHub] [bigtop] smallyao opened a new pull request, #993: [WIP]BIGTOP-3741:Add Flink support for Bigtop 3.1.0 Mpack

smallyao opened a new pull request, #993:
URL: https://github.com/apache/bigtop/pull/993

   <!--
     Thanks for sending a pull request!
       1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute
       2. Make sure your PR title starts with JIRA issue id, e.g., 'BIGTOP-3638: Your PR title ...'.
   -->
   
   ### Description of PR
   
   
   ### How was this patch tested?
   
   
   ### For code changes:
   
   - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'BIGTOP-3638. Your PR title ...')?
   - [ ] Make sure that newly added files do not have any licensing issues. When in doubt refer to https://www.apache.org/licenses/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bigtop] kevinw66 commented on pull request #993: BIGTOP-3741:Add Flink support for Bigtop 3.1.0 Mpack

Posted by GitBox <gi...@apache.org>.
kevinw66 commented on PR #993:
URL: https://github.com/apache/bigtop/pull/993#issuecomment-1236292930

   Can we have custom configs like other components?
   ![image](https://user-images.githubusercontent.com/31196226/188305841-565d3177-1f3b-4026-bf93-b65d6939f34b.png)
   ![image](https://user-images.githubusercontent.com/31196226/188305850-d09f8407-59a1-47a6-8a42-660a624b286a.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bigtop] smallyao commented on pull request #993: BIGTOP-3741:Add Flink support for Bigtop 3.1.0 Mpack

Posted by GitBox <gi...@apache.org>.
smallyao commented on PR #993:
URL: https://github.com/apache/bigtop/pull/993#issuecomment-1236600337

   Thanks for your review.
   In current flink configs web, we can directly add/delete/update configuration in flink-conf template or log4j related textarea.
   
   
   > Can we have custom configs like other components? ![image](https://user-images.githubusercontent.com/31196226/188305841-565d3177-1f3b-4026-bf93-b65d6939f34b.png) ![image](https://user-images.githubusercontent.com/31196226/188305850-d09f8407-59a1-47a6-8a42-660a624b286a.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bigtop] guyuqi commented on pull request #993: BIGTOP-3741:Add Flink support for Bigtop 3.1.0 Mpack

Posted by GitBox <gi...@apache.org>.
guyuqi commented on PR #993:
URL: https://github.com/apache/bigtop/pull/993#issuecomment-1241797676

   Verified on the local host enabling Kerberos, +1
   ![1662719246477](https://user-images.githubusercontent.com/20575685/189329919-2bb66b37-2ce1-4aee-9388-cacf219c03a6.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bigtop] guyuqi merged pull request #993: BIGTOP-3741:Add Flink support for Bigtop 3.1.0 Mpack

Posted by GitBox <gi...@apache.org>.
guyuqi merged PR #993:
URL: https://github.com/apache/bigtop/pull/993


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bigtop] smallyao commented on pull request #993: BIGTOP-3741:Add Flink support for Bigtop 3.1.0 Mpack

Posted by GitBox <gi...@apache.org>.
smallyao commented on PR #993:
URL: https://github.com/apache/bigtop/pull/993#issuecomment-1236602481

   > Can we have custom configs like other components? ![image](https://user-images.githubusercontent.com/31196226/188305841-565d3177-1f3b-4026-bf93-b65d6939f34b.png) ![image](https://user-images.githubusercontent.com/31196226/188305850-d09f8407-59a1-47a6-8a42-660a624b286a.png)
   
   Thanks for your review.
   In current flink configs web, we can directly add/delete/update configuration in flink-conf template or log4j related textarea.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bigtop] kevinw66 commented on pull request #993: BIGTOP-3741:Add Flink support for Bigtop 3.1.0 Mpack

Posted by GitBox <gi...@apache.org>.
kevinw66 commented on PR #993:
URL: https://github.com/apache/bigtop/pull/993#issuecomment-1236622420

   +1 LGTM, @guyuqi Could you please take a look, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bigtop] kevinw66 commented on pull request #993: BIGTOP-3741:Add Flink support for Bigtop 3.1.0 Mpack

Posted by GitBox <gi...@apache.org>.
kevinw66 commented on PR #993:
URL: https://github.com/apache/bigtop/pull/993#issuecomment-1236293116

   I can still see errors while running service_check
   ![image](https://user-images.githubusercontent.com/31196226/188305875-aaa3c8fc-a508-45f4-afee-7a5fd27ccef0.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bigtop] guyuqi commented on pull request #993: BIGTOP-3741:Add Flink support for Bigtop 3.1.0 Mpack

Posted by GitBox <gi...@apache.org>.
guyuqi commented on PR #993:
URL: https://github.com/apache/bigtop/pull/993#issuecomment-1241798691

   Merged, thanks @smallyao 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bigtop] smallyao commented on pull request #993: BIGTOP-3741:Add Flink support for Bigtop 3.1.0 Mpack

Posted by GitBox <gi...@apache.org>.
smallyao commented on PR #993:
URL: https://github.com/apache/bigtop/pull/993#issuecomment-1236600006

   Thanks for your review.
   In current flink configs web, we can directly add/delete/update configuration in flink-conf template or log4j related textarea.
   
   
   > Can we have custom configs like other components? ![image](https://user-images.githubusercontent.com/31196226/188305841-565d3177-1f3b-4026-bf93-b65d6939f34b.png) ![image](https://user-images.githubusercontent.com/31196226/188305850-d09f8407-59a1-47a6-8a42-660a624b286a.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bigtop] smallyao commented on pull request #993: BIGTOP-3741:Add Flink support for Bigtop 3.1.0 Mpack

Posted by GitBox <gi...@apache.org>.
smallyao commented on PR #993:
URL: https://github.com/apache/bigtop/pull/993#issuecomment-1236610044

   > I can still see errors while running service_check ![image](https://user-images.githubusercontent.com/31196226/188305875-aaa3c8fc-a508-45f4-afee-7a5fd27ccef0.png)
   
   Fixed, thanks @kevinw66 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org