You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/12/15 11:24:23 UTC
[GitHub] [flink-connector-pulsar] snuyanzin opened a new pull request, #7: [FLINK-30426] Set `archRule.failOnEmptyShould = false` to return old behavior
snuyanzin opened a new pull request, #7:
URL: https://github.com/apache/flink-connector-pulsar/pull/7
In ArchUnit 1.0.0 there was added a breaking change [1]
```
As mentioned in Enhancements/Core ArchRules will now by default reject evaluating if the set passed to the should-clause is empty. This will break existing rules that don't check any elements in their should-clause. You can restore the old behavior by setting the ArchUnit property archRule.failOnEmptyShould=false
```
As a result all the rules which do no match anything will fail.
Also since Flink 1.17-SNAPSHOT depends on 1.0.0 ArchUnit, this version was updated to be synced
[1] https://github.com/TNG/ArchUnit/releases/tag/v0.23.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-pulsar] boring-cyborg[bot] commented on pull request #7: [FLINK-30426] Set `archRule.failOnEmptyShould = false` to return old behavior
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #7:
URL: https://github.com/apache/flink-connector-pulsar/pull/7#issuecomment-1352921258
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-pulsar] snuyanzin commented on pull request #7: [FLINK-30426] Set `archRule.failOnEmptyShould = false` to return old behavior
Posted by GitBox <gi...@apache.org>.
snuyanzin commented on PR #7:
URL: https://github.com/apache/flink-connector-pulsar/pull/7#issuecomment-1352983899
>which meant that the flink-architecture-tests-production and flink-architecture-tests-test were built with Archunit 1.0.0?
yes, that's the reason
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-pulsar] MartijnVisser merged pull request #7: [FLINK-30426] Set `archRule.failOnEmptyShould = false` to return old behavior
Posted by GitBox <gi...@apache.org>.
MartijnVisser merged PR #7:
URL: https://github.com/apache/flink-connector-pulsar/pull/7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-pulsar] MartijnVisser commented on pull request #7: [FLINK-30426] Set `archRule.failOnEmptyShould = false` to return old behavior
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #7:
URL: https://github.com/apache/flink-connector-pulsar/pull/7#issuecomment-1352980042
@snuyanzin Thanks a lot. What I don't fully understand is the actual cause: was it because this repo depends on 1.17-SNAPSHOT, which meant that the `flink-architecture-tests-production` and `flink-architecture-tests-test` were built with Archunit 1.0.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-pulsar] boring-cyborg[bot] commented on pull request #7: [FLINK-30426] Set `archRule.failOnEmptyShould = false` to return old behavior
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #7:
URL: https://github.com/apache/flink-connector-pulsar/pull/7#issuecomment-1352986038
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-pulsar] MartijnVisser commented on pull request #7: [FLINK-30426] Set `archRule.failOnEmptyShould = false` to return old behavior
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #7:
URL: https://github.com/apache/flink-connector-pulsar/pull/7#issuecomment-1352985260
> yes, that's the reason
Ugh. That's freakingly annoying.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org