You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "francisoliverlee (via GitHub)" <gi...@apache.org> on 2023/04/12 05:47:08 UTC
[GitHub] [rocketmq] francisoliverlee commented on a diff in pull request #6575: [ISSUE #6574] fix DefaultMQProducerImpl.request sync invoke tome out
francisoliverlee commented on code in PR #6575:
URL: https://github.com/apache/rocketmq/pull/6575#discussion_r1163648462
##########
client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java:
##########
@@ -1563,34 +1554,38 @@ public void request(final Message msg, final MessageQueue mq, final RequestCallb
prepareSendRequest(msg, timeout);
final String correlationId = msg.getProperty(MessageConst.PROPERTY_CORRELATION_ID);
- final RequestResponseFuture requestResponseFuture = new RequestResponseFuture(correlationId, timeout, requestCallback);
- RequestFutureHolder.getInstance().getRequestFutureTable().put(correlationId, requestResponseFuture);
+ RequestFutureHolder.getInstance().getRequestFutureTable().put(correlationId,
+ new RequestResponseFuture(correlationId, timeout, requestCallback));
long cost = System.currentTimeMillis() - beginTimestamp;
this.sendKernelImpl(msg, mq, CommunicationMode.ASYNC, new SendCallback() {
@Override
public void onSuccess(SendResult sendResult) {
- requestResponseFuture.setSendRequestOk(true);
+ requestSuccess(correlationId, new Message(msg.getTopic(), msg.getBody()));
Review Comment:
how about message's properties ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org