You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2021/05/20 12:26:14 UTC
[GitHub] [knox] smolnar82 opened a new pull request #450: KNOX-2606 - Indicate configured token TTL on UI and ask for confirmation when end-users try to generate a token above the configured limit
smolnar82 opened a new pull request #450:
URL: https://github.com/apache/knox/pull/450
## What changes were proposed in this pull request?
In order to avoid misunderstandings and customer escalations, the token generation UI now indicates what is the configured maximum lifetime (`knox.token.ttl` in the relevant topology). In case end-users wants to generate a token that exceeds the configured maximum, a confirmation window is shown where we explain the side effects.
Please note that if `knox.token.ttl` is set to `-1` the topology owner explicitly configured `unlimited lifetime`, so we do not need to check the supplied lifespan.
## How was this patch tested?
Manually tested.
<img width="618" alt="Screen Shot 2021-05-20 at 1 54 02 PM" src="https://user-images.githubusercontent.com/34065904/118978093-35375e80-b977-11eb-8bf6-8716dc4abcc3.png">
<img width="631" alt="Screen Shot 2021-05-20 at 1 53 32 PM" src="https://user-images.githubusercontent.com/34065904/118978127-3ff1f380-b977-11eb-9609-8d1def815d0c.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 merged pull request #450: KNOX-2606 - Indicate configured token TTL on UI and ask for confirmation when end-users try to generate a token above the configured limit
Posted by GitBox <gi...@apache.org>.
smolnar82 merged pull request #450:
URL: https://github.com/apache/knox/pull/450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org