You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2020/08/05 09:57:43 UTC

[GitHub] [sling-org-apache-sling-auth-core] cziegeler commented on pull request #1: Strings and Boxed types should be compared using "equals()"

cziegeler commented on pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/1#issuecomment-669101239


   Thanks for the PR - the current code looks strange, however with the suggest PR a NPE might occur as sudo might be null. The current boolean is taking this into account. I think a much better way would be to remove that boolean and the setCookie check and adjust the following if blocks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org