You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwebbeans.apache.org by Gurkan Erdogdu <gu...@yahoo.com> on 2010/02/10 06:44:15 UTC
Code Conventions
Hello folks;
While committing code into our code base, it is good idea to have following and obey our formatter rules
1* Remove unused imports
2* Try to get rid of generic warnings
3* Use correct line bracing and tab space
4* Use SVN properties
Thanks;
--Gurkan
___________________________________________________________________
Yahoo! Türkiye açıldı! http://yahoo.com.tr
İnternet üzerindeki en iyi içeriği Yahoo! Türkiye sizlere sunuyor!
Re: Code Conventions
Posted by Matthias Wessendorf <ma...@apache.org>.
2010/2/10 Gurkan Erdogdu <cg...@gmail.com>:
> Hi Joe,
>
>>>>Along these lines, what is the general feeling about committing changes
>>>>without an associated JIRA issue?
> We must not do :) Actually we have to always include JIRA-Id for committing
> but we are sometimes lazy. From now on, as a general rule; before committing
> some codes, always attach JIRA id if it exists, and if there is no JIRA
> create a new one. WDYT?
generally that si fine; MyFaces does the same.
But, e.g. changing poms etc doesn't really need that.
>
>>>>Also I've found the Eclipse formatter you sent a while back to be very
>>>>useful for auto-formatting new files. Perhaps we should add a link to
> this
>>>>from the website for any new developers.
> Yes, it is very useful. Otherwise every committer use run its own formatter
> rules :)
>
> Thanks;
>
> --Gurkan
>
> 10 Şubat 2010 16:56 tarihinde Joseph Bergmark <be...@gmail.com> yazdı:
>
>> Along these lines, what is the general feeling about committing changes
>> without an associated JIRA issue? I've been opening sometimes trivial JIRA
>> issues in order to associate them with any commit I do, but I'm not sure if
>> this is required or not.
>>
>> Also I've found the Eclipse formatter you sent a while back to be very
>> useful for auto-formatting new files. Perhaps we should add a link to this
>> from the website for any new developers.
>>
>> Sincerely,
>>
>> Joe
>>
>> On Wed, Feb 10, 2010 at 12:44 AM, Gurkan Erdogdu <gurkanerdogdu@yahoo.com
>> >wrote:
>>
>> > Hello folks;
>> >
>> > While committing code into our code base, it is good idea to have
>> following
>> > and obey our formatter rules
>> >
>> > 1* Remove unused imports
>> > 2* Try to get rid of generic warnings
>> > 3* Use correct line bracing and tab space
>> > 4* Use SVN properties
>> >
>> > Thanks;
>> >
>> > --Gurkan
>> >
>> >
>> >
>> > ___________________________________________________________________
>> > Yahoo! Türkiye açıldı! http://yahoo.com.tr
>> > İnternet üzerindeki en iyi içeriği Yahoo! Türkiye sizlere sunuyor!
>> >
>>
>
>
>
> --
> Gurkan Erdogdu
> http://gurkanerdogdu.blogspot.com
>
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
Re: Code Conventions
Posted by Mark Struberg <st...@yahoo.de>.
Hi folks!
For _small_ cleanup stuff, you can use OWB-275 which I created today in the morning extra for that purpose :)
LieGrue,
strub
--- Gurkan Erdogdu <cg...@gmail.com> schrieb am Mi, 10.2.2010:
> Von: Gurkan Erdogdu <cg...@gmail.com>
> Betreff: Re: Code Conventions
> An: dev@openwebbeans.apache.org
> Datum: Mittwoch, 10. Februar 2010, 16:19
> Hi Joe,
>
> >>>Along these lines, what is the general feeling
> about committing changes
> >>>without an associated JIRA issue?
> We must not do :) Actually we have to always include
> JIRA-Id for committing
> but we are sometimes lazy. From now on, as a general rule;
> before committing
> some codes, always attach JIRA id if it exists, and
> if there is no JIRA
> create a new one. WDYT?
>
> >>>Also I've found the Eclipse formatter you sent
> a while back to be very
> >>>useful for auto-formatting new files.
> Perhaps we should add a link to
> this
> >>>from the website for any new developers.
> Yes, it is very useful. Otherwise every committer use run
> its own formatter
> rules :)
>
> Thanks;
>
> --Gurkan
>
> 10 Şubat 2010 16:56 tarihinde Joseph Bergmark <be...@gmail.com>
> yazdı:
>
> > Along these lines, what is the general feeling about
> committing changes
> > without an associated JIRA issue? I've been
> opening sometimes trivial JIRA
> > issues in order to associate them with any commit I
> do, but I'm not sure if
> > this is required or not.
> >
> > Also I've found the Eclipse formatter you sent a while
> back to be very
> > useful for auto-formatting new files. Perhaps we
> should add a link to this
> > from the website for any new developers.
> >
> > Sincerely,
> >
> > Joe
> >
> > On Wed, Feb 10, 2010 at 12:44 AM, Gurkan Erdogdu
> <gurkanerdogdu@yahoo.com
> > >wrote:
> >
> > > Hello folks;
> > >
> > > While committing code into our code base, it is
> good idea to have
> > following
> > > and obey our formatter rules
> > >
> > > 1* Remove unused imports
> > > 2* Try to get rid of generic warnings
> > > 3* Use correct line bracing and tab space
> > > 4* Use SVN properties
> > >
> > > Thanks;
> > >
> > > --Gurkan
> > >
> > >
> > >
> > >
> ___________________________________________________________________
> > > Yahoo! Türkiye açıldı! http://yahoo.com.tr
> > > İnternet üzerindeki en iyi içeriği Yahoo!
> Türkiye sizlere sunuyor!
> > >
> >
>
>
>
> --
> Gurkan Erdogdu
> http://gurkanerdogdu.blogspot.com
>
__________________________________________________
Do You Yahoo!?
Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz gegen Massenmails.
http://mail.yahoo.com
Re: Code Conventions
Posted by Gurkan Erdogdu <cg...@gmail.com>.
Hi Joe,
>>>Along these lines, what is the general feeling about committing changes
>>>without an associated JIRA issue?
We must not do :) Actually we have to always include JIRA-Id for committing
but we are sometimes lazy. From now on, as a general rule; before committing
some codes, always attach JIRA id if it exists, and if there is no JIRA
create a new one. WDYT?
>>>Also I've found the Eclipse formatter you sent a while back to be very
>>>useful for auto-formatting new files. Perhaps we should add a link to
this
>>>from the website for any new developers.
Yes, it is very useful. Otherwise every committer use run its own formatter
rules :)
Thanks;
--Gurkan
10 Şubat 2010 16:56 tarihinde Joseph Bergmark <be...@gmail.com> yazdı:
> Along these lines, what is the general feeling about committing changes
> without an associated JIRA issue? I've been opening sometimes trivial JIRA
> issues in order to associate them with any commit I do, but I'm not sure if
> this is required or not.
>
> Also I've found the Eclipse formatter you sent a while back to be very
> useful for auto-formatting new files. Perhaps we should add a link to this
> from the website for any new developers.
>
> Sincerely,
>
> Joe
>
> On Wed, Feb 10, 2010 at 12:44 AM, Gurkan Erdogdu <gurkanerdogdu@yahoo.com
> >wrote:
>
> > Hello folks;
> >
> > While committing code into our code base, it is good idea to have
> following
> > and obey our formatter rules
> >
> > 1* Remove unused imports
> > 2* Try to get rid of generic warnings
> > 3* Use correct line bracing and tab space
> > 4* Use SVN properties
> >
> > Thanks;
> >
> > --Gurkan
> >
> >
> >
> > ___________________________________________________________________
> > Yahoo! Türkiye açıldı! http://yahoo.com.tr
> > İnternet üzerindeki en iyi içeriği Yahoo! Türkiye sizlere sunuyor!
> >
>
--
Gurkan Erdogdu
http://gurkanerdogdu.blogspot.com
Re: Code Conventions
Posted by Joseph Bergmark <be...@gmail.com>.
Along these lines, what is the general feeling about committing changes
without an associated JIRA issue? I've been opening sometimes trivial JIRA
issues in order to associate them with any commit I do, but I'm not sure if
this is required or not.
Also I've found the Eclipse formatter you sent a while back to be very
useful for auto-formatting new files. Perhaps we should add a link to this
from the website for any new developers.
Sincerely,
Joe
On Wed, Feb 10, 2010 at 12:44 AM, Gurkan Erdogdu <gu...@yahoo.com>wrote:
> Hello folks;
>
> While committing code into our code base, it is good idea to have following
> and obey our formatter rules
>
> 1* Remove unused imports
> 2* Try to get rid of generic warnings
> 3* Use correct line bracing and tab space
> 4* Use SVN properties
>
> Thanks;
>
> --Gurkan
>
>
>
> ___________________________________________________________________
> Yahoo! Türkiye açıldı! http://yahoo.com.tr
> İnternet üzerindeki en iyi içeriği Yahoo! Türkiye sizlere sunuyor!
>
Re: Code Conventions
Posted by Jean-Louis MONTEIRO <je...@gmail.com>.
Hello,
Matthias, if you can get the link, i'd like to read the page.
Jean-Louis
2010/2/10 Matthias Wessendorf <ma...@apache.org>:
> Hi Gurkan,
>
> I think somewhere in Apache is a wiki page which has some good
> information on this topic as well
>
> -Matthias
>
> On Wed, Feb 10, 2010 at 6:44 AM, Gurkan Erdogdu <gu...@yahoo.com> wrote:
>> Hello folks;
>>
>> While committing code into our code base, it is good idea to have following and obey our formatter rules
>>
>> 1* Remove unused imports
>> 2* Try to get rid of generic warnings
>> 3* Use correct line bracing and tab space
>> 4* Use SVN properties
>>
>> Thanks;
>>
>> --Gurkan
>>
>>
>>
>> ___________________________________________________________________
>> Yahoo! Türkiye açıldı! http://yahoo.com.tr
>> İnternet üzerindeki en iyi içeriği Yahoo! Türkiye sizlere sunuyor!
>
>
>
> --
> Matthias Wessendorf
>
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> twitter: http://twitter.com/mwessendorf
>
Re: Code Conventions
Posted by Matthias Wessendorf <ma...@apache.org>.
Hi Gurkan,
I think somewhere in Apache is a wiki page which has some good
information on this topic as well
-Matthias
On Wed, Feb 10, 2010 at 6:44 AM, Gurkan Erdogdu <gu...@yahoo.com> wrote:
> Hello folks;
>
> While committing code into our code base, it is good idea to have following and obey our formatter rules
>
> 1* Remove unused imports
> 2* Try to get rid of generic warnings
> 3* Use correct line bracing and tab space
> 4* Use SVN properties
>
> Thanks;
>
> --Gurkan
>
>
>
> ___________________________________________________________________
> Yahoo! Türkiye açıldı! http://yahoo.com.tr
> İnternet üzerindeki en iyi içeriği Yahoo! Türkiye sizlere sunuyor!
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf