[jira] [Commented] (CALCITE-2206) Window functions pushed to JDBC databases regardless of their support

["Julian Hyde (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396111#comment-16396111 ] 

Julian Hyde commented on CALCITE-2206:
--------------------------------------

Reviewing [d502cc3|https://github.com/apache/calcite/pull/646/commits/d502cc39a498954c046021f85a6d88b59ef71937]:
* Can you deprecate the old JdbcConverterRule constructor
* Add RelBuilderFactory argument to new JdbcConverterRule so we don't have to refactor it again
* SqlDialect.supportsWindowFunctions needs javadoc



> Window functions pushed to JDBC databases regardless of their support
> ---------------------------------------------------------------------
>
>                 Key: CALCITE-2206
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2206
>             Project: Calcite
>          Issue Type: Bug
>          Components: jdbc-adapter
>    Affects Versions: 1.15.0
>            Reporter: Pavel Gubin
>            Assignee: Julian Hyde
>            Priority: Major
>
> Queries containing window functions fail when using HSQLDB (or any other DB that does not support window functions) because optimiser converts them to native SQL with window functions which are not supported by HSQLDB. For example:
> {code:sql}
> select "store_id", "product_id", sum("unit_sales") unit_sales, row_number() over (
> partition by "store_id" order by sum("unit_sales") desc
> ) row_num
> from "sales_fact_1998"
> group by "store_id", "product_id"
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)