You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/27 07:22:43 UTC
[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request, #9256: (Refactor)[Statistics] Fix lock risks in Statistics Job
EmmyMiao87 opened a new pull request, #9256:
URL: https://github.com/apache/incubator-doris/pull/9256
# Proposed changes
1. Remove lock nesting between job and task
2. Solve the deadlock problem during job update
3. Avoid printing the log while holding the lock
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a diff in pull request #9256: (Refactor)[Statistics] Fix lock risks in Statistics Job
Posted by GitBox <gi...@apache.org>.
yangzhg commented on code in PR #9256:
URL: https://github.com/apache/incubator-doris/pull/9256#discussion_r860427023
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsJobScheduler.java:
##########
@@ -86,7 +86,11 @@ protected void runAfterCatalogReady() {
LOG.info("The statistics task queue is full, schedule the job(id={}) later", pendingJob.getId());
} catch (DdlException e) {
pendingJobQueue.remove();
- pendingJob.updateJobState(StatisticsJob.JobState.FAILED);
+ try {
+ // TODO change to without exception
+ pendingJob.updateJobState(StatisticsJob.JobState.FAILED);
+ } catch (DdlException ddlException) {
+ }
Review Comment:
catch but no action ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9256: (Refactor)[Statistics] Fix lock risks in Statistics Job
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9256:
URL: https://github.com/apache/incubator-doris/pull/9256#issuecomment-1112091724
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a diff in pull request #9256: (Refactor)[Statistics] Fix lock risks in Statistics Job
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on code in PR #9256:
URL: https://github.com/apache/incubator-doris/pull/9256#discussion_r860431656
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsJobScheduler.java:
##########
@@ -86,7 +86,11 @@ protected void runAfterCatalogReady() {
LOG.info("The statistics task queue is full, schedule the job(id={}) later", pendingJob.getId());
} catch (DdlException e) {
pendingJobQueue.remove();
- pendingJob.updateJobState(StatisticsJob.JobState.FAILED);
+ try {
+ // TODO change to without exception
+ pendingJob.updateJobState(StatisticsJob.JobState.FAILED);
+ } catch (DdlException ddlException) {
+ }
Review Comment:
I will add a LOG(FATAL)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei merged pull request #9256: (Refactor)[Statistics] Fix lock risks in Statistics Job
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #9256:
URL: https://github.com/apache/incubator-doris/pull/9256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9256: (Refactor)[Statistics] Fix lock risks in Statistics Job
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9256:
URL: https://github.com/apache/incubator-doris/pull/9256#issuecomment-1111699544
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9256: (Refactor)[Statistics] Fix lock risks in Statistics Job
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9256:
URL: https://github.com/apache/incubator-doris/pull/9256#issuecomment-1111699560
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org