You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/22 08:48:23 UTC
[GitHub] [incubator-nuttx] anchao opened a new pull request, #6891: drivers/rwbuffer: Fix compiler errors
anchao opened a new pull request, #6891:
URL: https://github.com/apache/incubator-nuttx/pull/6891
## Summary
drivers: Fix compiler errors
riscv64-unknown-elf-ld: staging/libdrivers.a(rwbuffer.o): in function `rwb_flush':
rwbuffer.c:(.text.rwb_flush+0x12): undefined reference to `rwb_forcetake'
Signed-off-by: chenwen@espressif.com <ch...@espressif.com>
Signed-off-by: chao.an <an...@xiaomi.com>
## Impact
N/A
## Testing
define CONFIG_DRVR_WRDELAY 0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6891: drivers/rwbuffer: Fix compiler errors
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6891:
URL: https://github.com/apache/incubator-nuttx/pull/6891#discussion_r951215809
##########
drivers/misc/rwbuffer.c:
##########
@@ -76,13 +76,11 @@ static int rwb_semtake(FAR sem_t *sem)
{
return nxsem_wait_uninterruptible(sem);
Review Comment:
let's change rwb_semtake to macro
##########
drivers/misc/rwbuffer.c:
##########
@@ -76,13 +76,11 @@ static int rwb_semtake(FAR sem_t *sem)
{
return nxsem_wait_uninterruptible(sem);
}
-#endif
/****************************************************************************
* Name: rwb_forcetake
****************************************************************************/
-#if defined(CONFIG_DRVR_WRITEBUFFER) && CONFIG_DRVR_WRDELAY != 0
Review Comment:
remove " && CONFIG_DRVR_WRDELAY != 0"
##########
drivers/misc/rwbuffer.c:
##########
@@ -106,13 +104,17 @@ static int rwb_forcetake(FAR sem_t *sem)
return ret;
}
-#endif
/****************************************************************************
* Name: rwb_semgive
****************************************************************************/
#define rwb_semgive(s) nxsem_post(s)
+#else
+# define rwb_forcetake(s) OK
Review Comment:
don't need
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6891: drivers/rwbuffer: Fix compiler errors
Posted by GitBox <gi...@apache.org>.
anchao commented on code in PR #6891:
URL: https://github.com/apache/incubator-nuttx/pull/6891#discussion_r951357870
##########
drivers/misc/rwbuffer.c:
##########
@@ -76,13 +76,11 @@ static int rwb_semtake(FAR sem_t *sem)
{
return nxsem_wait_uninterruptible(sem);
Review Comment:
Done
##########
drivers/misc/rwbuffer.c:
##########
@@ -106,13 +104,17 @@ static int rwb_forcetake(FAR sem_t *sem)
return ret;
}
-#endif
/****************************************************************************
* Name: rwb_semgive
****************************************************************************/
#define rwb_semgive(s) nxsem_post(s)
+#else
+# define rwb_forcetake(s) OK
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6891: drivers/rwbuffer: Fix compiler errors
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6891:
URL: https://github.com/apache/incubator-nuttx/pull/6891
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6891: drivers/rwbuffer: Fix compiler errors
Posted by GitBox <gi...@apache.org>.
anchao commented on code in PR #6891:
URL: https://github.com/apache/incubator-nuttx/pull/6891#discussion_r951358093
##########
drivers/misc/rwbuffer.c:
##########
@@ -76,13 +76,11 @@ static int rwb_semtake(FAR sem_t *sem)
{
return nxsem_wait_uninterruptible(sem);
}
-#endif
/****************************************************************************
* Name: rwb_forcetake
****************************************************************************/
-#if defined(CONFIG_DRVR_WRITEBUFFER) && CONFIG_DRVR_WRDELAY != 0
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6891: drivers/rwbuffer: Fix compiler errors
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6891:
URL: https://github.com/apache/incubator-nuttx/pull/6891#issuecomment-1222486188
Let's ignore the false alarm from check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org