You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Jens Geyer (JIRA)" <ji...@apache.org> on 2013/10/08 23:24:43 UTC

[jira] [Commented] (THRIFT-1751) definition of increase_max_fds doesn't compile when HAVE_SYS_RESOURCE_H is not defined

    [ https://issues.apache.org/jira/browse/THRIFT-1751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13789712#comment-13789712 ] 

Jens Geyer commented on THRIFT-1751:
------------------------------------

Since you are ifdef'ing the whole function away: Would it make sense to ifdef the prototype in the header file too?

> definition of increase_max_fds doesn't compile when HAVE_SYS_RESOURCE_H is not defined
> --------------------------------------------------------------------------------------
>
>                 Key: THRIFT-1751
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1751
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.9, 1.0
>            Reporter: Ben Craig
>            Assignee: Ben Craig
>             Fix For: 1.0
>
>         Attachments: TServer_guard.patch
>
>
> The definition of increase_max_fds uses struct rlimit, which is defined in sys/resource.h.  If sys/resource.h doesn't get included, you get a compiler error.



--
This message was sent by Atlassian JIRA
(v6.1#6144)