[GitHub] [skywalking] kezhenxu94 commented on a diff in pull request #9789: Fix metrics was put into wrong slot of the window in the alarting kernel

[GitBox <gi...@apache.org>]

kezhenxu94 commented on code in PR #9789:
URL: https://github.com/apache/skywalking/pull/9789#discussion_r996269608


##########
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RunningRule.java:
##########
@@ -222,7 +222,9 @@ private boolean validate(String target, List<String> includeList, List<String> e
      * @param targetTime of moving target
      */
     public void moveTo(LocalDateTime targetTime) {
-        windows.values().forEach(window -> window.moveTo(targetTime));
+        //format targetTime to minute ,make sure the second is `00` and millisSeconds is `00` such as: 18:30:00.000

Review Comment:
   ```suggestion
           // Truncate targetTime to minute, make sure the second is `00` and milliseconds is `00` such as: 18:30:00.000
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org