You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by GitBox <gi...@apache.org> on 2022/08/19 13:37:34 UTC
[GitHub] [curator] snuyanzin opened a new pull request, #433: CURATOR-538: address from InetSocketAddress could be null as it means unresolved address
snuyanzin opened a new pull request, #433:
URL: https://github.com/apache/curator/pull/433
To be aligned with contract of `java.net.InetSocketAddress` it should take into account that `java.net.InetSocketAddress#getAddress` could return `null` which will mean unresolved address
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] tisonkun merged pull request #433: CURATOR-538: address from InetSocketAddress could be null as it means unresolved address
Posted by GitBox <gi...@apache.org>.
tisonkun merged PR #433:
URL: https://github.com/apache/curator/pull/433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] snuyanzin commented on pull request #433: CURATOR-538: address from InetSocketAddress could be null as it means unresolved address
Posted by GitBox <gi...@apache.org>.
snuyanzin commented on PR #433:
URL: https://github.com/apache/curator/pull/433#issuecomment-1230415910
hi @tisonkun thanks for the response
in fact there are 3 jira issues for the same situation CURATOR-597, CURATOR-538, CURATOR-649
every fails with NPE since the address was marked as unresolved and as a result it tries to host from address...
but at the same time for unresolved addresses address is `null`.... The idea is return `unknown` in case of unresolved addresses as for other exceptions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org